Opened 10 years ago
Closed 10 years ago
#10157 closed defect (fixed)
#9799 breaks bdisted binaries (lacking pipestatus)
Reported by: | jdemeyer | Owned by: | jdemeyer |
---|---|---|---|
Priority: | blocker | Milestone: | sage-4.6.1 |
Component: | distribution | Keywords: | scripts |
Cc: | jhpalmieri | Merged in: | sage-4.6.1.alpha0 |
Authors: | Jeroen Demeyer | Reviewers: | John Palmieri |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
Attachments (1)
Change History (15)
comment:1 Changed 10 years ago by
- Milestone changed from sage-4.6 to sage-4.6.1
comment:2 Changed 10 years ago by
- Description modified (diff)
Changed 10 years ago by
comment:3 Changed 10 years ago by
- Description modified (diff)
- Owner changed from tbd to jdemeyer
comment:4 follow-up: ↓ 8 Changed 10 years ago by
- Status changed from new to needs_review
Good catch. I didn't know the bdists didn't have spkg/pipestatus
.
comment:5 Changed 10 years ago by
- Description modified (diff)
comment:6 Changed 10 years ago by
- Cc jhpalmieri added
In principle positive review; should test this of course (later).
comment:7 Changed 10 years ago by
If you thrust the author of the patch to do the test, I am doing the following:
- building Sage from source with #9799, #10156, #10157 applied and makefile renamed to Makefile
- making an sdist and a bdist from this built Sage
- extract the sdist, make, make ptestlong
- extract the bdist, make ptestlong
If all this works, I think that #10156 and #10157 are proven to work.
comment:8 in reply to: ↑ 4 Changed 10 years ago by
Replying to leif:
Good catch. I didn't know the bdists didn't have
spkg/pipestatus
.
Well, the "catch" was made because the above recipe failed.
comment:9 Changed 10 years ago by
- Summary changed from #9799 breaks bdisted binaries to #9799 breaks bdisted binaries (lacking pipestatus)
comment:10 Changed 10 years ago by
comment:11 Changed 10 years ago by
- Merged in set to sage-4.6.1.alpha0
comment:12 Changed 10 years ago by
- Merged in changed from sage-4.6.1.alpha0 to sage-4.6.1.alpha1
comment:13 Changed 10 years ago by
- Reviewers set to John Palmieri
- Status changed from needs_review to positive_review
The patch looks completely sensible, and it's worked for me when I tested it out.
comment:14 Changed 10 years ago by
- Merged in changed from sage-4.6.1.alpha1 to sage-4.6.1.alpha0
- Resolution set to fixed
- Status changed from positive_review to closed
Set "merged" to sage-4.6.1.alpha1 by mistake (this patch didn't change).
Note: See
TracTickets for help on using
tickets.
sage_scripts patch