Opened 10 years ago
Closed 10 years ago
#10150 closed enhancement (fixed)
Change add_constraint to add_linear_constraint in the new LP interfaces
| Reported by: | ncohen | Owned by: | ncohen |
|---|---|---|---|
| Priority: | major | Milestone: | sage-4.6.1 |
| Component: | linear programming | Keywords: | |
| Cc: | malb, mvngu | Merged in: | sage-4.6.1.alpha1 |
| Authors: | Nathann Cohen | Reviewers: | Martin Albrecht |
| Report Upstream: | N/A | Work issues: | |
| Branch: | Commit: | ||
| Dependencies: | Stopgaps: |
Description
This patch renames the add_constraint methods defined in the LP solver interfaces to add_linear_constraint, as Martin wisely requested it.
Nathann
Apply first :
This long list of undeserved dependencies is here to prevent any higher-level patch from having to be rebased, as these patches tend to touch many files almost everywhere.
Attachments (1)
Change History (6)
comment:1 Changed 10 years ago by
- Status changed from new to needs_review
Changed 10 years ago by
comment:2 Changed 10 years ago by
- Cc mvngu added
comment:3 Changed 10 years ago by
comment:4 Changed 10 years ago by
- Reviewers set to Martin Albrecht
- Status changed from needs_review to positive_review
make ptestlong passes.
comment:5 Changed 10 years ago by
- Merged in set to sage-4.6.1.alpha1
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
The patch does exactly what it advertises and applies cleanly against 4.6.1.alpha0. I'm running doctests now. If those finish without errors I'll give this patch a positive review.