Opened 12 years ago
Closed 12 years ago
#10089 closed defect (fixed)
Fix stdsage.pxi include in sage/rings/finite_rings/element_givaro.pyx
Reported by: | jdemeyer | Owned by: | tba |
---|---|---|---|
Priority: | minor | Milestone: | sage-4.6 |
Component: | c_lib | Keywords: | |
Cc: | Merged in: | sage-4.6.alpha3 | |
Authors: | Jeroen Demeyer | Reviewers: | Robert Bradshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
Compiling sage/rings/finite_rings/element_givaro.pyx
gives a warning
warning: /usr/local/src/sage-debug/devel/sage-main/sage/rings/finite_rings/element_givaro.pyx:68:21: Function signature does not match previous declaration
because stdsage.pxi
is not included properly (there are comments indicating trouble with stdsage.pxi
but in sage-4.6.alpha2 I could not find any problems).
Attachments (1)
Change History (6)
Changed 12 years ago by
comment:1 Changed 12 years ago by
- Description modified (diff)
comment:2 Changed 12 years ago by
- Status changed from new to needs_review
comment:3 Changed 12 years ago by
- Status changed from needs_review to positive_review
comment:4 Changed 12 years ago by
- Reviewers set to Robert Bradshaw
comment:5 Changed 12 years ago by
- Merged in set to sage-4.6.alpha3
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Looks good to me. The comment was probably a workaround for a bug in some old version of Cython.