Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#10079 closed defect (fixed)

Typo in doc of symbolic/relation.py

Reported by: jpflori Owned by: mvngu
Priority: trivial Milestone: sage-4.6.1
Component: documentation Keywords:
Cc: Merged in: sage-4.6.1.alpha0
Authors: Jean-Pierre Flori Reviewers: Minh Van Nguyen
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

GitHub link to the corresponding issue

Description (last modified by mvngu)

In sage/symbolic/relation.py inside a warning block a "{does}" should be replaced by "*does*".

I provided a patch.

Apply:

Attachments (2)

typo_in_doc_symbolic_relation.patch (1.0 KB) - added by jpflori 12 years ago.
Patch correcting the typo.
trac-10079_typo-fix-symbolic-relation.patch (993 bytes) - added by mvngu 12 years ago.

Download all attachments as: .zip

Change History (6)

Changed 12 years ago by jpflori

Patch correcting the typo.

comment:1 Changed 12 years ago by mvngu

Status: newneeds_review

comment:2 Changed 12 years ago by mvngu

Authors: Jean-Pierre Flori
Description: modified (diff)
Milestone: sage-4.6
Reviewers: Minh Van Nguyen
Status: needs_reviewpositive_review

I'm OK with jpflori's patch. However, note that it doesn't have the ticket number in the commit message. The ticket number is very useful when debugging merge conflicts between patches to be merged, and those patches that are already in Sage. The patch trac-10079_typo-fix-symbolic-relation.patch is the same as jpflori's patch, but with the ticket number in the commit message. Positive review to jpflori's fix. See the ticket description for instruction on which ticket to merge.

comment:3 Changed 12 years ago by jdemeyer

Merged in: sage-4.6.1.alpha0
Resolution: fixed
Status: positive_reviewclosed

comment:4 Changed 12 years ago by mpatel

Milestone: sage-4.6sage-4.6.1
Note: See TracTickets for help on using tickets.