Opened 10 years ago

Closed 10 years ago

#10067 closed defect (fixed)

Another broken docstring in is_even_hole_free

Reported by: ncohen Owned by: jason, ncohen, rlm
Priority: major Milestone: sage-4.6.1
Component: graph theory Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

Just casting this BipartiteGraph? to a graph is sufficient.

Nathann

Attachments (1)

trac_10067.patch (765 bytes) - added by ncohen 10 years ago.

Download all attachments as: .zip

Change History (7)

Changed 10 years ago by ncohen

comment:1 follow-up: Changed 10 years ago by ncohen

  • Status changed from new to needs_review

comment:2 follow-up: Changed 10 years ago by mpatel

See comment 20ff at #9925 for a flaky doctest that #9422 and #10067 should fix.

comment:3 in reply to: ↑ 2 Changed 10 years ago by mpatel

Replying to mpatel:

See comment 20ff at #9925 for a flaky doctest that #9422 and #10067 should fix.

I've opened #10081 for this failure.

comment:4 in reply to: ↑ 1 Changed 10 years ago by dimpase

  • Status changed from needs_review to needs_info

Replying to ncohen:

This patch looks pretty weird. It essentially says that methods is_even_hole_free() and is_forest() cannot be applied to an instance of BipartiteGraph?. Why is that? Isn't BipartiteGraph? inheriting from Graph?

IMHO it looks like you cure a symptom rather than the root of the problem.

comment:5 Changed 10 years ago by ncohen

You're right. I gave you my best attempt at a reply in #10081.

Nathann

comment:6 Changed 10 years ago by ncohen

  • Resolution set to fixed
  • Status changed from needs_info to closed

Fixed by #10081

Note: See TracTickets for help on using tickets.