Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#10036 closed enhancement (fixed)

SageNB 0.8.6

Reported by: mpatel Owned by: jason, was
Priority: major Milestone: sage-4.6
Component: notebook Keywords:
Cc: acleone, jason, kcrisman, timdumol Merged in:
Authors: Mitesh Patel Reviewers: Jason Grout
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by jason)

Merged in SageNB 0.8.3: #9000, #9148, #9327, #9822.

Merged in SageNB 0.8.4: #9920.

Merged in SageNB 0.8.5: #9828.

Merged in SageNB 0.8.6: #9920 (devel/ fix).

Release manager

Please merge

More specifically:

Then do sage -ba to refresh the Cython files.

Change History (20)

comment:1 Changed 9 years ago by mpatel

  • Authors set to Mitesh Patel
  • Cc acleone jason kcrisman timdumol added
  • Description modified (diff)
  • Milestone set to sage-4.6
  • Status changed from new to needs_review

The long doctests pass for me with 4.6.alpha2 + SageNB 0.8.3 on sage.math.

My current local setup is limited, so I don't know about the Selenium tests. As far as I'm aware, we still need to update the SageNB Se tests for the latest released version of Selenium RC.

comment:2 follow-up: Changed 9 years ago by jason

It would be really great if #9920 were slipped into this as well.

What do we need to do to review this? We already reviewed the individual patches.

comment:3 Changed 9 years ago by mpatel

  • Description modified (diff)

comment:4 Changed 9 years ago by mpatel

  • Summary changed from SageNB 0.8.3 to SageNB 0.8.4

comment:5 in reply to: ↑ 2 Changed 9 years ago by mpatel

Replying to jason:

What do we need to do to review this? We already reviewed the individual patches.

I think you can just check that I didn't make a mistake in applying the right tickets, install the package, run the doctests.

comment:7 Changed 9 years ago by mpatel

  • Description modified (diff)

comment:8 Changed 9 years ago by mpatel

Could someone please review the package?

comment:9 Changed 9 years ago by mpatel

  • Summary changed from SageNB 0.8.4 to SageNB 0.8.5

comment:10 follow-up: Changed 9 years ago by mpatel

There's an error building Sage from scratch. See #9920 for the problem.

comment:11 Changed 9 years ago by mpatel

  • Description modified (diff)
  • Summary changed from SageNB 0.8.5 to SageNB 0.8.6

comment:12 in reply to: ↑ 10 Changed 9 years ago by mpatel

Replying to mpatel:

There's an error building Sage from scratch. See #9920 for the problem.

Fixed in 0.8.6, which needs a [formal] review for 4.6.alpha3.

comment:13 Changed 9 years ago by jason

  • Description modified (diff)

I'm a little confused at what to do to test this. I've updated the description. Did I get everything?

comment:14 Changed 9 years ago by jason

  • Description modified (diff)

comment:15 follow-up: Changed 9 years ago by vbraun

In #10094 I'm switching on c++ support in cython-0.13, this changes (actually, fixes) one sage.misc.sageinspect.py doctest. The analogous change needs to be made to sagenb.misc.sageinspect.py when/if that patch is accepted. Its simple: http://trac.sagemath.org/sage_trac/attachment/ticket/10094/trac_10094_fix_doctests.patch

comment:16 Changed 9 years ago by jason

  • Status changed from needs_review to positive_review

Okay, I followed the steps in the description (using 4.6.alpha2), on a production server running behind an apache proxy. ptestlong passed all tests, and I was successfully able to log in, run worksheets, create accounts, etc. So positive review.

comment:17 in reply to: ↑ 15 Changed 9 years ago by jason

Replying to vbraun:

In #10094 I'm switching on c++ support in cython-0.13, this changes (actually, fixes) one sage.misc.sageinspect.py doctest. The analogous change needs to be made to sagenb.misc.sageinspect.py when/if that patch is accepted. Its simple: http://trac.sagemath.org/sage_trac/attachment/ticket/10094/trac_10094_fix_doctests.patch

This change has already been made in one of the patches merged into 0.8.6, so nothing needs to be done.

comment:18 Changed 9 years ago by jason

  • Reviewers set to Jason Grout

comment:19 Changed 9 years ago by mpatel

  • Merged in set to sage-4.6.alpha3
  • Resolution set to fixed
  • Status changed from positive_review to closed

Thanks, Jason!

comment:20 Changed 9 years ago by mpatel

  • Merged in sage-4.6.alpha3 deleted

I'm merging #10097's 0.8.7 package, which supersedes 0.8.6.

Note: See TracTickets for help on using tickets.