Opened 10 years ago
Closed 10 years ago
#10030 closed enhancement (fixed)
Interrupt testing
Reported by: | jdemeyer | Owned by: | tba |
---|---|---|---|
Priority: | major | Milestone: | sage-4.7 |
Component: | c_lib | Keywords: | interrupt signal doctest |
Cc: | leif, wjp | Merged in: | sage-4.7.alpha1 |
Authors: | Jeroen Demeyer | Reviewers: | Volker Braun |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
Attachments (3)
Change History (24)
comment:1 Changed 10 years ago by
- Description modified (diff)
comment:2 Changed 10 years ago by
- Description modified (diff)
comment:3 Changed 10 years ago by
- Description modified (diff)
comment:4 Changed 10 years ago by
- Description modified (diff)
- Keywords signal added
comment:5 Changed 10 years ago by
- Description modified (diff)
comment:6 Changed 10 years ago by
- Description modified (diff)
- Status changed from new to needs_work
comment:7 Changed 10 years ago by
- Description modified (diff)
comment:8 Changed 10 years ago by
- Description modified (diff)
comment:9 Changed 10 years ago by
- Description modified (diff)
comment:10 Changed 10 years ago by
- Milestone changed from sage-feature to sage-4.6.2
- Status changed from needs_work to needs_review
comment:11 Changed 10 years ago by
- Description modified (diff)
comment:12 Changed 10 years ago by
comment:13 Changed 10 years ago by
- Cc wjp added
comment:14 Changed 10 years ago by
- Reviewers set to Volker Braun
- Status changed from needs_review to needs_work
I think the issue is that "...
" expects to match something but does not match the empty line
<BLANKLINE>
. Note the difference between
- Linux: will print stack backtrace before "Unhandled SIGABRT", and
- OSX: does not print stack backtrace.
For example, changing
sage: print '---'; print Popen(['sage', '-c', cmd], stdout=PIPE, stderr=PIPE).communicate()[1] # long time
to
sage: print '---'; print 'backtrace:'; print Popen(['sage', '-c', cmd], stdout=PIPE, stderr=PIPE).communicate()[1] # long time
fixes the doctest on OSX, as now at least 'backtrace:'
gets matched by the "
...
".
comment:15 Changed 10 years ago by
- Status changed from needs_work to needs_review
Okay, I didn't know that ...
needs to match at least one non-blank character (apparently). I fixed it in the most simple way by replacing ---\n...
by -...
comment:16 Changed 10 years ago by
- Status changed from needs_review to positive_review
Looks good! I tested it on bsd.math and all doctests pass.
comment:17 Changed 10 years ago by
- Milestone changed from sage-4.6.2 to sage-4.7
comment:18 Changed 10 years ago by
- Status changed from positive_review to needs_work
comment:19 Changed 10 years ago by
- Status changed from needs_work to needs_review
comment:21 Changed 10 years ago by
- Merged in set to sage-4.7.alpha1
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
On OS X, I get doctest "failures"::
It looks to me that the "Got" text matches the "Expected" text, so why is this a failure?