Opened 11 years ago

Closed 11 years ago

#10019 closed enhancement (fixed)

big performance issue with variance and std

Reported by: ylchapuy Owned by: amhou
Priority: major Milestone: sage-4.6
Component: statistics Keywords:
Cc: Merged in: sage-4.6.alpha2
Authors: Yann Laigle-Chapuy Reviewers: Mike Hansen
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

Try this and wait 1 hour (estimated)

sage: variance([1] * 2^18)

This should be fast.

Attachments (2)

trac10019-variance_perf_issue.patch (1.6 KB) - added by ylchapuy 11 years ago.
trac10019-fix_doc_build.patch (611 bytes) - added by ylchapuy 11 years ago.

Download all attachments as: .zip

Change History (8)

Changed 11 years ago by ylchapuy

comment:1 Changed 11 years ago by ylchapuy

  • Authors set to Yann Laigle-Chapuy
  • Status changed from new to needs_review

Luckily, the solution is easy.

comment:2 Changed 11 years ago by mhansen

  • Reviewers set to Mike Hansen
  • Status changed from needs_review to positive_review

Looks good to me.

comment:3 Changed 11 years ago by mpatel

  • Merged in set to sage-4.6.alpha2
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:4 Changed 11 years ago by mpatel

  • Merged in sage-4.6.alpha2 deleted
  • Status changed from closed to needs_work

Actually, I get a docbuild warning:

/mnt/usb1/scratch/mpatel/tmp/sage-4.6.alpha1-working/local/lib/python2.6/site-packages/sage/stats/basic_stats.py:docstring of sage.stats.basic_stats.variance:53: (WARNING/2) Literal block expected; none found.

I've unmerged the patch.

Changed 11 years ago by ylchapuy

comment:5 Changed 11 years ago by ylchapuy

  • Status changed from needs_work to positive_review

Oups, sorry. Fixed. (apply both patches)

comment:6 Changed 11 years ago by mpatel

  • Merged in set to sage-4.6.alpha2
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.