Opened 10 years ago

Closed 10 years ago

#10002 closed enhancement (fixed)

Eliminate use of Gp in number_field.py

Reported by: jdemeyer Owned by: davidloeffler
Priority: major Milestone: sage-4.6.1
Component: number fields Keywords: pari gp number field
Cc: Merged in: sage-4.6.1.alpha2
Authors: Jeroen Demeyer Reviewers: John Cremona
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

The file sage/rings/number_field/number_field.py uses the GP interpreter for some computations. It is probably more efficient to use the PARI library instead.

Dependencies: #9898, #9753, #4836, #10012

Attachments (1)

10002_remove_gp.patch (4.3 KB) - added by jdemeyer 10 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 10 years ago by jdemeyer

  • Description modified (diff)

Changed 10 years ago by jdemeyer

comment:2 Changed 10 years ago by jdemeyer

  • Status changed from new to needs_review

comment:3 Changed 10 years ago by cremona

  • Authors set to Jeroen Demeyer
  • Reviewers set to John Cremona
  • Status changed from needs_review to positive_review

Applies fine to 4.6.1.alpha0.

It's a great idea to remove use of gp interpreter wherever possible. And since one of my to-do items is to handle S-unit groups (and S-class groups) as well as we do unit and class groups, and this will help, I am all in favour -- thanks!

I tested all sage/rings/number_fields and sage/schemes/elliptic_curves (since 2-descent code uses S-units), and all pass.

comment:4 Changed 10 years ago by jdemeyer

  • Merged in set to sage-4.6.1.alpha2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.