1. Make your new code the default over QQ.
2. Change these doctests:
12 sage: from sage.schemes.elliptic_curves.ell_int_points import integral_points
13 sage: integral_points(E)
to
E.integral_points()
3. Delete this line?
318 #assert M1==M2
4. Write a sentence saying what the function _d8, _d9, etc., any
function should have a sentence at the top explaining what it
computes/does:
349 def _d8(E, L, Elog, Periods, D7):
350 r"""
351 INPUT:
352
5. Feature request ? It would be cool if this worked:
sage: E = ... define a curve ...
sage: E.faltings_height()
23.23920348902384
which would be easy given that you have "def _Faltings_height(E):"
in your code.
6. The docstring formatting looks incredibly sloppy in some cases, e.g.
787 with some torsion point `T` and `|q_i| \leq Q`.
788 INPUT:
789
790 - ``E`` -- an elliptic curve
791
792 - ``L`` -- a basis for the Mordel-Weil group of `E`
793
794 - ``Q`` -- positive integer, maximum for the absolute bound on all coefficients in the linear combination of points in `L`
795
796 OUTPUT:
797
798 Returns the sequence of all integral points modulo `[-1]`
It's weird that there is no blankline before "INPUT:", and that
"OUTPUT:" is indented a lot more than the actual output. Just saying.