Ticket #9054: trac_9054_review_fixup.patch

File trac_9054_review_fixup.patch, 2.0 KB (added by saraedum, 6 years ago)

patches to mderickx's review comments

  • sage/rings/function_field/function_field.py

    # HG changeset patch
    # User Julian Rueth <julian.rueth@gmail.com>
    Trac 9054: fixes relating to the review comments by mderickx
    
    diff --git a/sage/rings/function_field/function_field.py b/sage/rings/function_field/function_field.py
    index 7cf9a0e..29ab6ae 100644
    a b class FunctionField(Field): 
    120120            sage: False in [e in K for e in elements]
    121121            False
    122122         """
    123          return [self.random_element()]
     123         return [self.random_element(), self.random_element(), self.random_element()]
    124124
    125125    def characteristic(self):
    126126        """
    class FunctionField_polymod(FunctionField): 
    712712        from maps import MapVectorSpaceToFunctionField, MapFunctionFieldToVectorSpace
    713713        from_V = MapVectorSpaceToFunctionField(V, self)
    714714        to_V   = MapFunctionFieldToVectorSpace(self, V)
    715         self._vector_space = (V, from_V, to_V)
    716         return self._vector_space
     715        return (V, from_V, to_V)
    717716       
    718717    def maximal_order(self):
    719718        """
    class RationalFunctionField(FunctionField): 
    12071206        from maps import MapVectorSpaceToFunctionField, MapFunctionFieldToVectorSpace
    12081207        from_V = MapVectorSpaceToFunctionField(V, self)
    12091208        to_V   = MapFunctionFieldToVectorSpace(self, V)
    1210         self._vector_space = (V, from_V, to_V)
    1211         return self._vector_space
     1209        return (V, from_V, to_V)
    12121210
    12131211    def random_element(self, *args, **kwds):
    12141212        """
  • sage/rings/function_field/function_field_order.py

    diff --git a/sage/rings/function_field/function_field_order.py b/sage/rings/function_field/function_field_order.py
    index f872e49..7602cad 100644
    a b class FunctionFieldOrder(IntegralDomain): 
    5151        """
    5252        INPUT:
    5353
    54             - ``fraction_field`` -- the function field in which this iss an order.
     54            - ``fraction_field`` -- the function field in which this is an order.
    5555
    5656        EXAMPLES::
    5757