Ticket #3738: coercion_comments1.txt

File coercion_comments1.txt, 1.9 KB (added by rlm, 11 years ago)
Line 
1There are no docs in generators.
2
3sage/structure/parent.pyx:128 - What is the syntax foo(bar=None, *, etc=None) doing? Does it throw away all but the first non-kwd arg?
4
5Why not always pass the parent (_unique morphism)?
6
7sage/structure/parent.pyx:256 (typo) this it will always be
8
9In the Parent class, why is it not the case that __call__ delegates to coerce?
10
11sage/structure/parent.pyx:256 - needs to be wrapped in a list to prevent modification
12
13sage/structure/parent.pyx:~438 - Hom vs. hom should be explained in docs (definitions are there, but perhaps a warning)
14
15sage/structure/parent.pyx:597-9 etc. - should this be a copy?
16
17sage/structure/parent.pyx:530-1 - why not use the _generic_convert_map here? why does coerce_list use _generic_convert_map? what is the difference?
18
19sage/structure/parent.pyx:807-24 - needs to be resolved
20
21sage/structure/parent.pyx:839 - what does '"best"' mean? (868 - will this change in future patches?)
22
23Can you clarify why _coerce_map_from_ is checked for overrides, but there is no such check for conversion?
24
25Why was coerce graph removed? :-(
26
27sage/structure/category_object.pyx:500 WHY ARE YOU WRITING Pyrex?
28
29All the comment blocks at the beginning of files are in the old style. i.e. copyright 2006... etc.
30
31Sometime it's pretty hard to figure out what's going on because there is some pretty damn random stuff with no docs or comments at all. (not a blocking comment, just saying...)
32
33Why are inexact morphisms bad, Mommy?
34
35sage/structure/coerce_actions - Why are left and right different, my friends? Python?
36
37sage/structure/coerce_actions.pyx:193 - typo "rikght"
38
39The inplace stuff needs more explanation.
40
41In coerce_map.pyx, "differs" should be "defers" in several places.
42
43There are a lot of if-else statements which special case out things which are automatically handled by Python syntax. Is this for speed?
44
45sage/structure/coerce.pyx gets four thumbs up.
46
47