Ticket #13615: trac_13615_fix.patch

File trac_13615_fix.patch, 2.0 KB (added by cremona, 6 years ago)

small fix for trac_13615_combined_4th_review.patch

  • sage/schemes/elliptic_curves/ell_rational_field.py

    # HG changeset patch
    # User John Cremona <john.cremona@gmail.com>
    # Date 1378565056 -3600
    # Node ID b5fe9b030d3804c170c274fd35163efa1220f035
    # Parent  ce233236fb95917980a0473a2ffc2eddc5db5c60
    #13615: added back primality test in isogenies_prime_degree
    
    diff --git a/sage/schemes/elliptic_curves/ell_rational_field.py b/sage/schemes/elliptic_curves/ell_rational_field.py
    a b  
    41994199        if l in [2, 3, 5, 7, 13]:
    42004200            return isogenies_prime_degree_genus_0(self, l)
    42014201        elif l != None and type(l) != list:
    4202             return isogenies_sporadic_Q(self, l)
     4202            try:
     4203                if l.is_prime(proof=False):
     4204                    return isogenies_sporadic_Q(self, l)
     4205                else:
     4206                    raise ValueError("%s is not prime."%l)
     4207            except AttributeError:
     4208                raise ValueError("%s is not prime."%l)
    42034209        if l == None:
    42044210            isogs = isogenies_prime_degree_genus_0(self)
    42054211            if isogs != []:
  • sage/schemes/elliptic_curves/isogeny_small_degree.py

    diff --git a/sage/schemes/elliptic_curves/isogeny_small_degree.py b/sage/schemes/elliptic_curves/isogeny_small_degree.py
    a b  
    257257       ``E.isogenies_prime_degree(l)``, which automatically calls the
    258258       appropriate function.
    259259
    260     ALGORITHM::
     260    ALGORITHM:
    261261
    262262    Cremona and Watkins [CW2005]_. See also [KT2013]_, Chapter 4.
    263263
     
    15071507       This function would normally be invoked indirectly via
    15081508       ``E.isogenies_prime_degree(l)``, which automatically calls the appropriate function.
    15091509
    1510     ALGORITHM::
     1510    ALGORITHM:
    15111511
    15121512    See [KT2013]_, Chapter 5.
    15131513
     
    18491849
    18501850    (list) a list of all isogenies of degree l.
    18511851
    1852     ALGORITHM::
     1852    ALGORITHM:
    18531853
    18541854    This algorithm factors the ``l``-division polynomial, then
    18551855    combines its factors to otain kernels. See [KT2013]_, Chapter 3.