Ticket #12876: trac_12876-reviewer.patch

File trac_12876-reviewer.patch, 5.8 KB (added by SimonKing, 8 years ago)
  • sage/categories/hecke_modules.py

    # HG changeset patch
    # User Simon King <simon.king@uni-jena.de>
    # Date 1335535211 -7200
    # Node ID 22d3e64793e13122fb576a3d888b06bd34c813c4
    # Parent  d70a2de8ff53f38aabbc295d55fb90e44ef9499d
    #12876: Reviewer patch: Some cosmetic changes in the docs
    
    diff --git a/sage/categories/hecke_modules.py b/sage/categories/hecke_modules.py
    a b  
    100100            The sole purpose of this method is to construct the homset
    101101            as a :class:`~sage.modular.hecke.homspace.HeckeModuleHomspace`. If
    102102            ``category`` is specified and is not a subcategory of
    103             :class:`HeckeModules`(), a ``TypeError`` is raised instead
     103            :class:`HeckeModules`, a ``TypeError`` is raised instead
    104104
    105105            This method is not meant to be called directly. Please use
    106106            :func:`sage.categories.homset.Hom` instead.
     
    114114                <class 'sage.modular.hecke.homspace.HeckeModuleHomspace_with_category'>
    115115                sage: TestSuite(H).run(skip=["_test_zero", "_test_elements"])
    116116
    117             Fixing :meth:'_test_zero' (``__call__`` should accept a
     117            Fixing :meth:`_test_zero` (``__call__`` should accept a
    118118            function as input) and :meth:`_test_elements` (modular
    119119            form morphisms elements should inherit from categories) is
    120             :trac:'???'.
     120            :trac:`???`.
    121121
    122122            TESTS::
    123123
  • sage/categories/homset.py

    diff --git a/sage/categories/homset.py b/sage/categories/homset.py
    a b  
    153153        TypeError: Integer Ring is not in Category of groups
    154154
    155155    A parent may specify how to construct certain homsets by
    156     implementing a method :meth:`_Hom_`(codomain, category). This
     156    implementing a method ``_Hom_(self, codomain, category)``. This
    157157    method should either construct the requested homset or raise a
    158158    ``TypeError``. This hook is currently mostly used to create
    159159    homsets in some specific subclass of :class:`Homset`
     
    177177    That's to say, the hom set found in the cache will have a (co)domain that is
    178178    equal to, but not identic with, the given (co)domain.
    179179
    180     By :trac:`9138`, we abandon the uniqueness of hom sets, if the domain or
     180    By :trac:`9138`, we abandon the uniqueness of homsets, if the domain or
    181181    codomain break uniqueness::
    182182
    183183        sage: from sage.rings.polynomial.multi_polynomial_ring import MPolynomialRing_polydict_domain
     
    230230        sage: Hom(PA,PJ, Rngs())
    231231        Set of Morphisms from <type 'sage.structure.parent.Parent'> to <type 'sage.structure.parent.Parent'> in Category of rngs
    232232
    233     TODO: design decision: how much of the homset comes from the
    234     category of X and Y, and how much from the specific X and Y.  In
    235     particular, do we need several parent classes depending on X and
    236     Y, or does the difference only lie in the elements (i.e. the
    237     morphism), and of course how the parent calls their constructors.
     233    ..TODO::
     234
     235        design decision: how much of the homset comes from the
     236        category of `X` and `Y`, and how much from the specific `X` and `Y`.  In
     237        particular, do we need several parent classes depending on `X` and
     238        `Y`, or does the difference only lie in the elements (i.e. the
     239        morphism), and of course how the parent calls their constructors.
    238240
    239241    TESTS::
    240242
  • sage/categories/rings.py

    diff --git a/sage/categories/rings.py b/sage/categories/rings.py
    a b  
    105105            The sole purpose of this method is to construct the homset
    106106            as a :class:`~sage.rings.homset.RingHomset`. If
    107107            ``category`` is specified and is not a subcategory of
    108             :class:`Rings`(), a ``TypeError`` is raised instead
     108            :class:`Rings`, a ``TypeError`` is raised instead
    109109
    110110            This method is not meant to be called directly. Please use
    111111            :func:`sage.categories.homset.Hom` instead.
     
    151151            rings also inherits from the base class of
    152152            rings. Therefore, we implemented a ``__mul__``
    153153            method for parents, that calls a ``_mul_``
    154             method implemented here. See trac ticket #11068.
     154            method implemented here. See :trac:`11068`.
    155155
    156156            INPUT:
    157157
     
    233233            The code is copied from the base class of rings.
    234234            This is since there are rings that do not inherit
    235235            from that class, such as matrix algebras.  See
    236             trac ticket #11068.
     236            :trac:`11068`.
    237237
    238238            EXAMPLE::
    239239
     
    269269            :class:`~sage.rings.ring.Ring`. This is
    270270            because there are rings that do not inherit
    271271            from that class, such as matrix algebras.
    272             See trac ticket #11068.
     272            See :trac:`11068`.
    273273
    274274            INPUT:
    275275
     
    473473
    474474            ``MS`` is not an instance of :class:`~sage.rings.ring.Ring`.
    475475            But since its category was fully initalised (which is not
    476             by default, by trac ticket #11900), it is an instance of
     476            by default, by :trac:`11900`), it is an instance of
    477477            the parent class of the category of rings. The quotient
    478478            method is inherited from there::
    479479
  • sage/structure/parent.pyx

    diff --git a/sage/structure/parent.pyx b/sage/structure/parent.pyx
    a b  
    15151515            Set of Morphisms from Rational Field to Integer Ring in Category of sets
    15161516
    15171517        A parent may specify how to construct certain homsets by
    1518         implementing a method :meth:`_Hom_`(codomain, category).
     1518        implementing a method ``_Hom_(self, codomain, category)``.
    15191519        See :func:`~sage.categories.homset.Hom` for details.
    15201520        """
    15211521        from sage.categories.homset import Hom