Ticket #12478: trac_12478_fix_fan_error_typo.patch

File trac_12478_fix_fan_error_typo.patch, 1.8 KB (added by novoselt, 9 years ago)

  • sage/geometry/fan.py 

    # HG changeset patch
# User Andrey Novoseltsev <novoselt@gmail.com>
# Date 1328770680 25200
# Node ID 692f370704e26ed4cc2c89aae0f866a93efc2f1f
# Parent  c053db755451fccf9c3b3d3098ef33a7e2d376d4
Fix a typo in the error message of the Fan constructor.

diff --git a/sage/geometry/fan.py b/sage/geometry/fan.py
    a b  
    346346        Traceback (most recent call last):
    347347        ...
    348348        ValueError: you have provided 3 cones, but only 2 of them are maximal!
    349         Use discard_faces=False if you indeed need to construct a fan from
     349        Use discard_faces=True if you indeed need to construct a fan from
    350350        these cones.
    351351
    352352    Oops! There was a typo and ``cone2`` was listed twice as a generating cone
    … …  
    519519                    cones = generating_cones
    520520                else:
    521521                    raise ValueError("you have provided %d cones, but only %d "
    522                         "of them are maximal! Use discard_faces=False if you "
     522                        "of them are maximal! Use discard_faces=True if you "
    523523                        "indeed need to construct a fan from these cones." %
    524524                        (len(cones), len(generating_cones)))
    525525        elif discard_faces:

  • sage/schemes/generic/fano_toric_variety.py 

    diff --git a/sage/schemes/generic/fano_toric_variety.py b/sage/schemes/generic/fano_toric_variety.py
    a b  
    429429        Traceback (most recent call last):
    430430        ...
    431431        ValueError: you have provided 5 cones, but only 4 of them are maximal!
    432         Use discard_faces=False if you indeed need to construct a fan from
     432        Use discard_faces=True if you indeed need to construct a fan from
    433433        these cones.
    434434
    435435    These charts are technically correct, they just happened to list one of