Ticket #11935: trac11935_share_on_base_category.patch

sage/categories/bimodules.py

@@ -49 +49 @@
         self._left_base_ring = left_base
         self._right_base_ring = right_base
 
+    def _make_named_class_key(self, name):
+        return (self._left_base_ring.category(), self._right_base_ring.category())
+
     @classmethod
     def an_instance(cls):
         """

sage/categories/category.py

@@ -1786 +1786 @@
         False
 
     """
-    def _make_named_class(self, name, method_provider, cache = "ignore_reduction", **options):
+    def _make_named_class(self, name, method_provider, cache = False, **options):
         """
         Purpose: Create the parent/element/... class of ``self``.
 
@@ -1852 +1852 @@
             sage: loads(dumps(PC)) is PC
             True
         """
-        # Implementation: we use the cache functionality of
-        # dynamic_class, and specify that the result depends only on
-        # the classes this class is built from
-        # (e.g. ``self.ParentMethods`` and ``c.parent_class`` for each
-        # super category ``c`` of ``self``) and not on the reduction
-        # data (which includes ``self``).
-        return Category._make_named_class(self, name, method_provider,
-                                          cache=cache, **options)
+        cls = self.__class__
+        key = (cls, name, self._make_named_class_key(name))
+        try:
+            return self._make_named_class_cache[key]
+        except KeyError:
+            pass
+        result = Category._make_named_class(self, name, method_provider,
+                                            cache=cache, **options)
+        self._make_named_class_cache[key] = result
+        return result
+
+
+    @abstract_method
+    def _make_named_class_key(self, name):
+        pass
+
+    _make_named_class_cache = dict()
 
     def _subcategory_hook_(self, C):
         """
@@ -1948 +1957 @@
             Category.__init__(self)
         self._super_categories = list(super_categories)
 
+    def _make_named_class_key(self, name):
+        return tuple(getattr(cat, name) for cat in self._super_categories)
+
     def super_categories(self):
         """
         Returns the immediate super categories, as per :meth:`Category.super_categories`.

sage/categories/category_types.py

@@ -203 +203 @@
         Category.__init__(self, name)
         self.__base = base
 
+    def _make_named_class_key(self, name):
+        return self.__base.category()
+
     @classmethod
     def an_instance(cls):
         """