1 | 1. Make your new code the default over QQ. |
---|

2 | |
---|

3 | 2. Change these doctests: |
---|

4 | 12 sage: from sage.schemes.elliptic_curves.ell_int_points import integral_points |
---|

5 | 13 sage: integral_points(E) |
---|

6 | |
---|

7 | to |
---|

8 | |
---|

9 | E.integral_points() |
---|

10 | |
---|

11 | |
---|

12 | 3. Delete this line? |
---|

13 | |
---|

14 | 318 #assert M1==M2 |
---|

15 | |
---|

16 | |
---|

17 | 4. Write a sentence saying what the function _d8, _d9, etc., any |
---|

18 | function should have a sentence at the top explaining what it |
---|

19 | computes/does: |
---|

20 | |
---|

21 | 349 def _d8(E, L, Elog, Periods, D7): |
---|

22 | 350 r""" |
---|

23 | 351 INPUT: |
---|

24 | 352 |
---|

25 | |
---|

26 | 5. Feature request ? It would be cool if this worked: |
---|

27 | |
---|

28 | sage: E = ... define a curve ... |
---|

29 | sage: E.faltings_height() |
---|

30 | 23.23920348902384 |
---|

31 | |
---|

32 | which would be easy given that you have "def _Faltings_height(E):" |
---|

33 | in your code. |
---|

34 | |
---|

35 | 6. The docstring formatting looks incredibly sloppy in some cases, e.g. |
---|

36 | |
---|

37 | 787 with some torsion point `T` and `|q_i| \leq Q`. |
---|

38 | 788 INPUT: |
---|

39 | 789 |
---|

40 | 790 - ``E`` -- an elliptic curve |
---|

41 | 791 |
---|

42 | 792 - ``L`` -- a basis for the Mordel-Weil group of `E` |
---|

43 | 793 |
---|

44 | 794 - ``Q`` -- positive integer, maximum for the absolute bound on all coefficients in the linear combination of points in `L` |
---|

45 | 795 |
---|

46 | 796 OUTPUT: |
---|

47 | 797 |
---|

48 | 798 Returns the sequence of all integral points modulo `[-1]` |
---|

49 | |
---|

50 | It's weird that there is no blankline before "INPUT:", and that |
---|

51 | "OUTPUT:" is indented a lot more than the actual output. Just saying. |
---|

52 | |
---|

53 | |
---|

54 | |
---|

55 | |
---|