# Ticket #10973: report2.txt

File report2.txt, 1.4 KB (added by was, 11 years ago)

second short report -- looking good!

Line
11. Make your new code the default over QQ.
2
32. Change these doctests:
412              sage: from sage.schemes.elliptic_curves.ell_int_points import integral_points
513              sage: integral_points(E)
6
7to
8
9  E.integral_points()
10
11
123. Delete this line?
13
14318           #assert M1==M2
15
16
174. Write a sentence saying what the function _d8, _d9, etc., any
18function should have a sentence at the top explaining what it
19computes/does:
20
21        349     def _d8(E, L, Elog, Periods, D7):
22        350         r"""
23        351         INPUT:
24        352
25
265. Feature request ?  It would be cool if this worked:
27
28  sage: E = ... define a curve ...
29  sage: E.faltings_height()
30  23.23920348902384
31
32which would be easy given that you have "def _Faltings_height(E):"
34
356. The docstring formatting looks incredibly sloppy in some cases, e.g.
36
37        787         with some torsion point T and |q_i| \leq Q.
38        788         INPUT:
39        789
40        790         - E -- an elliptic curve
41        791
42        792         - L -- a basis for the Mordel-Weil group of E
43        793
44        794         - Q -- positive integer, maximum for the absolute bound on all coefficients in the linear combination of points in L
45        795
46        796             OUTPUT:
47        797
48        798         Returns the sequence of all integral points modulo [-1]
49
50It's weird that there is no blankline before "INPUT:", and that
51"OUTPUT:" is indented a lot more than the actual output.  Just saying.
52
53
54
55