Ticket #10187: 10187-Document-quoting-problem.patch

File 10187-Document-quoting-problem.patch, 1.7 KB (added by drkirkby, 9 years ago)

Document that quoting SAGE_LOCAL can cause problems. Correct a spelling error too.

  • SPKG.txt

    # HG changeset patch
    # User David Kirkby <david.kirkby@onetel.net>
    # Date 1291235691 0
    # Node ID daebf2c3ce1a8ec30a26a364dcd660939d6dfb10
    # Parent  3c32f4059a1c22f3cd3efc15fbe7024595a222af
    #10187 Document problems there may be if quoting SAGE_LOCAL.
    
    diff -r 3c32f4059a1c -r daebf2c3ce1a SPKG.txt
    a b  
    4242 * Delete the contents of the src/contrib/encodings/
    4343 * TODO - Add the ECL test suite, and an spkg-check file to run it.
    4444 * Note, the way we configure Sage, CXX and CXXFLAGS are unused.
     45 * Do NOT quote SAGE_LOCAL when setting CPPFLAGS and/or LDFLAGS,
     46   in spkg-install as this caused the build to break. See
     47   http://trac.sagemath.org/sage_trac/ticket/10187#comment:117
     48 
    4549
    4650== Changelog ==
    4751
    4852=== ecl-10.4.1 (David Kirkby, 11th November 2010) ===
    4953  * #10187 Update to the latest stable release of ECL, which is needed
    5054    to build on Fedora 14 (see #10185).
    51   * Addred the word "Error" in front of all error messages.
     55  * Added the word "Error" in front of all error messages.
    5256  * Added a TODO to add an spkg-check file. Doing this is not
    5357    trivial. The ECL developer has said the test code on the
    5458    ECL site is outdated, and ECL is not really designed to
  • spkg-install

    diff -r 3c32f4059a1c -r daebf2c3ce1a spkg-install
    a b  
    1414   CXXFLAG64=-m64
    1515fi
    1616
     17# Do NOT quote SAGE_LOCAL here, as has caused problems.
     18# See: http://trac.sagemath.org/sage_trac/ticket/10187#comment:117
     19
    1720CPPFLAGS="$CPPFLAGS -I$SAGE_LOCAL/include"
    1821LDFLAGS="$LDFLAGS -L$SAGE_LOCAL/lib"
    1922