Opened 4 years ago

Closed 3 years ago

#9947 closed defect (fixed)

expression not in canonical form

Reported by: zimmerma Owned by: burcin
Priority: major Milestone: sage-4.7.1
Component: symbolics Keywords: pynac
Cc: Merged in: sage-4.7.1.alpha1
Authors: Richard Kreckel, Burcin Erocal Reviewers: Karl-Dieter Crisman
Report Upstream: Fixed upstream, in a later stable release. Work issues:
Branch: Commit:
Dependencies: #11317 Stopgaps:

Description (last modified by burcin)

In some cases GiNaC leaves numeric objects in the terms of an add:

sage: a=(sqrt(4*(sqrt(3) - 5)*(sqrt(3) + 5) + 48) + 4*sqrt(3))/ (sqrt(3) + 5)
sage: a.imag()
sin(1/2*arctan2(0, -88* + 1))*sqrt(abs(4*(sqrt(3) - 5)*(sqrt(3) + 5) + 1))

See the output of the second argument of arctan2.

The term -88* is generated by the expair -22*4. This term should be moved to the overall coefficient.

See also #9913.

Attachments (1)

trac_9947-add_eval.patch (840 bytes) - added by burcin 4 years ago.
add doctest

Download all attachments as: .zip

Change History (6)

Changed 4 years ago by burcin

add doctest

comment:1 Changed 4 years ago by burcin

  • Authors set to Richard Kreckel, Burcin Erocal
  • Component changed from calculus to symbolics
  • Description modified (diff)
  • Keywords pynac added
  • Report Upstream changed from N/A to Fixed upstream, in a later stable release.
  • Status changed from new to needs_work
  • Summary changed from output bug in GiNaC to expression not in canonical form

This was fixed in GiNaC by Richard Kreckel. Here is the relevant patch:

http://www.ginac.de/ginac.git?p=ginac.git;a=commitdiff;h=e08cda1854bdb82f6706ec269233577690ae00e4

I applied the patch to pynac, so this will be fixed in the next release.

comment:2 Changed 3 years ago by burcin

  • Dependencies set to 11317
  • Status changed from needs_work to needs_review

New pynac package with the fix is at #11317.

comment:3 Changed 3 years ago by kcrisman

  • Reviewers set to Karl-Dieter Crisman
  • Status changed from needs_review to positive_review

Looks ok. Same comment as at #9891.

For instance, one could then allow an spkg maintainer to review the upstream fix. But that's not exactly what we want.

comment:4 Changed 3 years ago by jdemeyer

  • Dependencies changed from 11317 to #11317
  • Milestone changed from sage-4.7 to sage-4.7.1

comment:5 Changed 3 years ago by jdemeyer

  • Merged in set to sage-4.7.1.alpha1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.