Opened 3 years ago

Closed 4 months ago

# square root with all=True should not return ValueError but empty list

Reported by: Owned by: mstreng AlexGhitza major sage-5.12 algebra sd23 sd51 sqrt all mderickx, ruckers sage-5.12.beta3 Marco Streng and the person with trac account ruckers Alejandro Argaez, Angelos Koutsianas N/A

With Sage 4.4.4 and no relevant patches, I got the following:

```sage: FiniteField(3)(2).sqrt(all = True)
[]

sage: 2.sqrt(extend = False, all = True)
ValueError: square root of 2 not an integer

sage: FiniteField(next_prime(2^100))(2).sqrt(extend = False, all = True)
ValueError: self must be a square

sage: _.<a>=FiniteField(9)
sage: a.sqrt(extend = False, all = True)
ValueError: must be a perfect square.
```

At sage days 23 we agreed that square root with all=True should not raise an error. If no square roots exist, then it should return an empty list.

Right now, it returns an empty list for elements of small prime finite fields, but raises an error for integers, elements of large prime finite fields, and elements of non-prime finite fields.

apply

### comment:1 Changed 3 years ago by mstreng

• Description modified (diff)

### Changed 22 months ago by ruckers

Fixes the code: sage: 2.sqrt(extend = False, all = True)

### Changed 22 months ago by ruckers

Fixes the code: sage: FiniteField?(next_prime(2100))(2).sqrt(extend = False, all = True)

### comment:3 Changed 22 months ago by ruckers

I was not able to fix this code.

sage: _.<a>=FiniteField?(9)

sage: a.sqrt(extend = False, all = True)

ValueError?: must be a perfect square.

### comment:4 Changed 22 months ago by mstreng

Thanks! That bug has been around for too long :)

Why were you not able to fix the FiniteField(9) case?

Unfortunately, the patches need some more work, for the following three reasons.

• With my2.patch:
```sage: Zmod(7)(3).sqrt(extend=True)
sqrt3
sage: Zmod(7)(3).sqrt(all=True, extend=True)
[]
```
The second one should either output [sqrt3, -sqrt3] or raise NotImplementedError, but never an empty list.
• Patches must have your name and email address in them. This is done by putting your email address and name in your .hgrc file as specified here
• Add an example of the new functionality to the documentation:
• This helps the user understand what the function does.
• Through the doctesting framework, this prevents other people from accidentally breaking your added functionality.
• This is required for your patch to be able to get a positive review. In fact, the manual says that you should also mention the ticket number #9466 with your example.

If you have any questions, let me know!

### comment:5 Changed 4 months ago by mstreng

• Authors set to Marco Streng
• Cc ruckers added
• Description modified (diff)
• Keywords sd23 sd51 sqrt all added

Does anyone know who user "ruckers" is? (s)he should be added to the list of authors

apply 9466.patch

### comment:6 Changed 4 months ago by mstreng

• Authors changed from Marco Streng to Marco Streng and the person with trac account ruckers
• Status changed from new to needs_review

### comment:7 Changed 4 months ago by akoutsianas

• Reviewers set to Alejandro Argaez, Angelos Koutsianas
• Status changed from needs_review to positive_review

The patch passed all the tests for sage 5.11 version.

### comment:8 Changed 4 months ago by jdemeyer

• Milestone changed from sage-5.11 to sage-5.12

### comment:9 Changed 4 months ago by jdemeyer

• Merged in set to sage-5.12.beta3
• Resolution set to fixed
• Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.