Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#8736 closed defect (fixed)

Bug in computing radical of univariate polynomial

Reported by: johanbosman Owned by: AlexGhitza
Priority: minor Milestone: sage-4.4.1
Component: algebra Keywords:
Cc: Merged in: sage-4.4.1.alpha2
Authors: Johan Bosman Reviewers: Leif Leonhardy, Andrey Novoseltsev
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by johanbosman)

From #sage-devel:

<wjp> sage: R.<x> = GF(2)[]
<wjp> sage: (x^2).radical()
<wjp> 1

Attachments (2)

trac_8736_radical_fix.patch (2.7 KB) - added by johanbosman 4 years ago.
trac_8736_radical_fix_single_patch.patch (1.4 KB) - added by leif 4 years ago.
Johan's patch with first hunk deleted

Download all attachments as: .zip

Change History (11)

comment:1 Changed 4 years ago by johanbosman

  • Description modified (diff)

comment:2 Changed 4 years ago by johanbosman

  • Status changed from new to needs_review

comment:3 Changed 4 years ago by leif

I was told it is not bad to put the corresponding ticket number in the doctest and/or near the code that fixes an issue for later reference.

Changed 4 years ago by johanbosman

comment:4 Changed 4 years ago by johanbosman

Like this? ;)

comment:5 Changed 4 years ago by novoselt

  • Status changed from needs_review to needs_work
  • Work issues set to patch does not apply

Probably like that, but now this patch file contains two patches and does not apply cleanly. I know that if you remove the existing patch before repeating the export command, everything should be fine and you will get a nice new patch. Maybe there are better ways which I am not aware of. Otherwise the patch seems fine to me and passes all doctests (I ran them on the previous working version).

Changed 4 years ago by leif

Johan's patch with first hunk deleted

comment:6 Changed 4 years ago by leif

  • Status changed from needs_work to needs_review
  • Work issues patch does not apply deleted

It's easier to just edit the patch (i.e., delete the first hunk)...

comment:7 Changed 4 years ago by novoselt

  • Reviewers set to Leif Leonhardy, Andrey Novoseltsev
  • Status changed from needs_review to positive_review

comment:8 Changed 4 years ago by was

  • Merged in set to 4.4.1.alpha2
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:9 Changed 4 years ago by mvngu

  • Merged in changed from 4.4.1.alpha2 to sage-4.4.1.alpha2
Note: See TracTickets for help on using tickets.