Opened 4 years ago
Closed 4 years ago
#8630 closed defect (fixed)
Cusp forms constructor ignores the character and returns enormous space
Reported by: | davidloeffler | Owned by: | craigcitro |
---|---|---|---|
Priority: | blocker | Milestone: | sage-4.4 |
Component: | modular forms | Keywords: | |
Cc: | Merged in: | sage-4.4.alpha0 | |
Authors: | David Loeffler | Reviewers: | William Stein |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
sage: chi = DirichletGroup(109, CyclotomicField(3)).0 sage: CuspForms(chi, 2, base_ring = CyclotomicField(9)) Cuspidal subspace of dimension 442 of Modular Forms space of dimension 10, character [zeta3 + 1] and weight 2 over Cyclotomic Field of order 9 and degree6
*facepalm*
Attachments (2)
Change History (11)
comment:1 Changed 4 years ago by davidloeffler
- Milestone set to sage-4.4
- Status changed from new to needs_review
comment:2 Changed 4 years ago by davidloeffler
- Status changed from needs_review to needs_work
Changed 4 years ago by davidloeffler
comment:3 Changed 4 years ago by davidloeffler
- Status changed from needs_work to needs_review
comment:4 Changed 4 years ago by was
- Priority changed from major to blocker
comment:5 Changed 4 years ago by was
All doctests pass when this is applied against sage-4.3.5.
comment:6 Changed 4 years ago by was
- Status changed from needs_review to positive_review
- Below "ring" should be "modular symbols space":
117 def change_ring(self, R): 118 r""" 119 Return this ring with the base ring changed to the ring R.
- Here I think the sentence should end with ::
419 A more complicated example involving both a nontrivial character, and a 420 base field that is not minimal for that character:
It's really awesome that you sphinxified a bunch of docs, in addition to fixing the bug in this ticket.
comment:7 Changed 4 years ago by davidloeffler
Here's a tiny patch that corrects the two things you pointed out in the docstrings.
comment:8 Changed 4 years ago by davidloeffler
- Reviewers set to William Stein
comment:9 Changed 4 years ago by jhpalmieri
- Merged in set to sage-4.4.alpha0
- Resolution set to fixed
- Status changed from positive_review to closed
Merged in 4.4.alpha0:
- trac_8630.patch
- trac_8630_docfixes.patch
Note: See
TracTickets for help on using
tickets.
* wait, it's still wrong in certain nastly cases *