Opened 5 years ago

Closed 5 years ago

#6850 closed enhancement (fixed)

[with patch, positive review] follow-up to #6531: really add ring.pyx to reference manual

Reported by: mvngu Owned by: tba
Priority: minor Milestone: sage-4.1.2
Component: documentation Keywords: Rings documentation
Cc: davidloeffler, cremona Merged in: Sage 4.1.2.alpha0
Authors: Minh Van Nguyen Reviewers: John Cremona
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

The patch trac_6531-restify_generic_ring-rebase.patch at #6531 was intended to provide documentation and doctests for the module sage/rings/ring.pyx. It was also meant to add that module to the reference manual, but doesn't really make any changes to doc/en/reference/rings.rst to allow this.

Attachments (1)

trac_6850-add-ring.patch (7.6 KB) - added by mvngu 5 years ago.
depends on #6531

Download all attachments as: .zip

Change History (5)

Changed 5 years ago by mvngu

depends on #6531

comment:1 Changed 5 years ago by mvngu

  • Authors set to Minh Van Nguyen
  • Cc davidloeffler cremona added

The patch trac_6850-add-ring.patch actually adds the module sage/rings/ring.pyx to the reference manual and fixes some typos found in that module. It depends on #6531.

comment:2 Changed 5 years ago by mvngu

  • Summary changed from follow-up to #6531: really add ring.pyx to reference manual to [with patch, needs review] follow-up to #6531: really add ring.pyx to reference manual

comment:3 Changed 5 years ago by cremona

  • Keywords Rings documentation added
  • Reviewers set to John Cremona
  • Summary changed from [with patch, needs review] follow-up to #6531: really add ring.pyx to reference manual to [with patch, with positive review] follow-up to #6531: really add ring.pyx to reference manual

Sorry, that was my fault -- David's original patch did make the necessary changes to the .rst file but somehow that was carried forward into the patch I made.

The patch applies and builds fine (on top of the new one at #6531).

comment:4 Changed 5 years ago by mvngu

  • Merged in set to Sage 4.1.2.alpha0
  • Resolution set to fixed
  • Status changed from new to closed
  • Summary changed from [with patch, with positive review] follow-up to #6531: really add ring.pyx to reference manual to [with patch, positive review] follow-up to #6531: really add ring.pyx to reference manual
Note: See TracTickets for help on using tickets.