Opened 6 years ago
Closed 6 years ago
#3184 closed defect (fixed)
[with patch, with positive review] broken p-adic getslice
Reported by: | dmharvey | Owned by: | somebody |
---|---|---|---|
Priority: | major | Milestone: | sage-3.4.1 |
Component: | basic arithmetic | Keywords: | |
Cc: | craigcitro | Merged in: | |
Authors: | Reviewers: | ||
Report Upstream: | Work issues: | ||
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
(This ticket was split off from #2943)
This is okay:
sage: K = Qp(13,7) sage: R.<t> = K[] sage: a = 13^7*t^3 + K(169,4)*t - 13^4 sage: a[1:2] (13^2 + O(13^4))*t
This dies:
sage: t[0:1] [boom]
The original context for this bug was along the lines of (see #2943 for more examples):
sage: K = Qp(p,10) sage: C.<t> = LaurentSeriesRing(K) sage: D.<s> = PolynomialRing(C) sage: z = (1 + O(t)) + t*s^2 sage: z * z [boom]
Attachments (1)
Change History (7)
comment:1 Changed 6 years ago by mabshoff
- Milestone set to sage-3.0.2
comment:2 Changed 6 years ago by mabshoff
- Cc craigcitro added
Changed 6 years ago by roed
comment:3 Changed 6 years ago by roed
- Summary changed from broken p-adic getslice to [with patch, needs review] broken p-adic getslice
comment:4 Changed 6 years ago by jason
First comment: getslice is deprecated; it should be getitem now.
Second, there is a standard block of code for slicing...using that will make sure that things are consistent for people that understand python slices.
comment:5 Changed 6 years ago by dmharvey
- Summary changed from [with patch, needs review] broken p-adic getslice to [with patch, with positive review] broken p-adic getslice
Looks good to me.
comment:6 Changed 6 years ago by mabshoff
- Milestone changed from sage-3.4.2 to sage-3.4.1
- Resolution set to fixed
- Status changed from new to closed
Merged in Sage 3.4.1.alpha0.
Cheeers,
Michael
Note: See
TracTickets for help on using
tickets.
Craig has become a getslice expert, so let's CC him :)
Cheers,
Michael