Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#3159 closed enhancement (fixed)

[with patch; positive review] Patch adding soname to ntl shared library

Reported by: tabbott Owned by: mabshoff
Priority: major Milestone: sage-3.0.2
Component: packages: standard Keywords:
Cc: f.r.bissey@… Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

François Bissey and I merged our patches for adding library versioning and a soname to ntl's shared library and for building the static library without -fPIC and the shared library with -fPIC, and tested that they work for Debian and Gentoo builds. I believe that if this patch were applied upstream, SAGE would be able to stop patch the ntl makefile as well. I'm submitting it here so that it can be tested for a standard SAGE build, so we can be sure the patch works before submitting it to Victor Shoup.

Attachments (3)

ntl-dynamic-library.patch (2.0 KB) - added by tabbott 6 years ago.
spkg-install.patch (1.2 KB) - added by fbissey 6 years ago.
ntl-forget-version.patch (510 bytes) - added by tabbott 6 years ago.

Download all attachments as: .zip

Change History (10)

Changed 6 years ago by tabbott

comment:1 Changed 6 years ago by mabshoff

  • Summary changed from [with patch; needs review] Patch adding soname to ntl shared library to [with patch; positive review, pending changes] Patch adding soname to ntl shared library

Hi Tim, Francois,

the patch looks good, but as is it needs some changes to our spkg-install. I also noticed some other issues with some scripts in to the src directory, i.e. all shell scripts are missing a shebang, so that causes trouble with csh in some instances. Once I got those sorted out I will respin our spkg and merge this patch while I am at it.

Cheers,

Michael

comment:2 Changed 6 years ago by fbissey

Mea culpa! One of us should at least have thought about the spkg-install,
we were more concerned that it would work correctly with our distros and that
it was "minimal". Good thing is now libntl.a is correctly compiled without
-fpic and libntl.so is now completely compiled with -fpic.
I attach a tentative patch for spkg-install.

Cheers,
Francois

Changed 6 years ago by fbissey

comment:3 Changed 6 years ago by mabshoff

  • Summary changed from [with patch; positive review, pending changes] Patch adding soname to ntl shared library to [with patch; positive review] Patch adding soname to ntl shared library

I have fixed a small couple issues with the patch in

http://sage.math.washington.edu/home/mabshoff/release-cycles-3.0.2/alpha0/ntl-5.4.2.p3.spkg

I did not patch src/src/mfile, but the one in patches, so the new Debian package as well as the ebuild needs to take that into consideration. The spkg builds fine on OSX and Linux, so positive review.

Cheers,

Michael

comment:4 Changed 6 years ago by mabshoff

One more thing: When creating symbolic links in spkg-install do not make those links absolute since they will break Sage once it is moved or install to another location. I fixed that and a couple other things, so I am taking partial credit on this ticket :)

Cheers,

Michael

comment:5 Changed 6 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged in Sage 3.0.2.alpha0

comment:6 Changed 6 years ago by fbissey

I'll remember that. It was a _tentative_ patch :)

comment:7 Changed 6 years ago by tabbott

I noticed the spkg-install script now has the current NTL version number in it; I'm attaching a patch that copies libntl*.so that should avoid having to update the patch every time there's a new NTL release.

Changed 6 years ago by tabbott

Note: See TracTickets for help on using tickets.