Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#3148 closed enhancement (fixed)

[with patch, positive review] improved orthogonal functions

Reported by: fwclarke Owned by: was
Priority: major Milestone: sage-3.0.2
Component: calculus Keywords: orthogonal polynomials Maxima
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

The defects in the code for the hermite function in
sage/functions/orthogonal_polys.py which were noted and corrected in
#2336 apply equally to the other functions in that file.

The attached patch applies the same fix that worked for hermite to the
following functions:

chebyshev_T,
chebyshev_U,
gen_laguerre,
gen_legendre_P,
gen_legendre_Q,
jacobi_P,
laguerre,
legendre_P,
legendre_Q,
ultraspherical

This allows these polynomials to take much more general
arguments; see the examples given for legendre_P.

The functions:

gen_legendre_P,
gen_legendre_Q,
legendre_Q

no longer yield a string representing a Maxima expression when the
argument is a variable.

For m > n the function gen_legendre_Q(n, m, x)
has to be computed independently of Maxima. This part of the code may
need improving.

The introductory documentation has not been changed.

Attachments (1)

sage-3148.patch (9.7 KB) - added by fwclarke 6 years ago.

Download all attachments as: .zip

Change History (5)

Changed 6 years ago by fwclarke

comment:1 Changed 6 years ago by mabshoff

  • Summary changed from improved orthogonal functions to [with patch, needs review] improved orthogonal functions

comment:2 Changed 6 years ago by mhansen

  • Summary changed from [with patch, needs review] improved orthogonal functions to [with patch, positive review] improved orthogonal functions

Looks good to me. All the tests pass, and the patch definitely simplifies the code.

comment:3 Changed 6 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged in Sage 3.0.2.rc0

comment:4 Changed 6 years ago by mabshoff

  • Milestone changed from sage-3.0.3 to sage-3.0.2
Note: See TracTickets for help on using tickets.