Opened 6 years ago
Closed 5 years ago
#3108 closed enhancement (fixed)
[with patch, positive review] implement additive_order for elliptic curve points
Reported by: | was | Owned by: | davidloeffler |
---|---|---|---|
Priority: | major | Milestone: | sage-4.1.2 |
Component: | elliptic curves | Keywords: | |
Cc: | Merged in: | Sage 4.1.2.alpha0 | |
Authors: | John Cremona | Reviewers: | Chris Wuthrich |
Report Upstream: | Work issues: | ||
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
sage: E = EllipticCurve(GF(5),[1..5]) sage: P = E.lift_x(0) sage: P (0 : 2 : 1) sage: P.additive_order() --------------------------------------------------------------------------- <type 'exceptions.NotImplementedError'> Traceback (most recent call last) /Users/was/papers/submitted/kolyconj/<ipython console> in <module>() /Users/was/papers/submitted/kolyconj/element.pyx in sage.structure.element.ModuleElement.additive_order() <type 'exceptions.NotImplementedError'>: sage: P.order() 3
Attachments (1)
Change History (7)
comment:1 Changed 6 years ago by was
- Type changed from defect to enhancement
comment:2 Changed 5 years ago by davidloeffler
- Component changed from number theory to elliptic curves
- Owner changed from was to davidloeffler
Changed 5 years ago by cremona
comment:3 Changed 5 years ago by cremona
comment:4 Changed 5 years ago by cremona
- Summary changed from implement additive_order for elliptic curve points to [with patch, needs review] implement additive_order for elliptic curve points
comment:5 Changed 5 years ago by wuthrich
- Summary changed from [with patch, needs review] implement additive_order for elliptic curve points to [with patch, positive review] implement additive_order for elliptic curve points
Fine.
Maybe David Loeffler, working on abelian groups, wants this differently.
By now, this should go in.
chris.
comment:6 Changed 5 years ago by mvngu
- Merged in set to Sage 4.1.2.alpha0
- Resolution set to fixed
- Reviewers set to Chris Wuthrich
- Status changed from new to closed
Note: See
TracTickets for help on using
tickets.
Done: I defined additive_order to be a synonym for order (in 3 places) with relevant doctests.