Opened 7 years ago

Closed 6 years ago

#3053 closed defect (fixed)

[with patch; positive review] notebook -- new cell_resize doesn't respect %hide at the beginning of a cell

Reported by: was Owned by: boothby
Priority: major Milestone: sage-3.0.2
Component: notebook Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

If a cell starts with %hide, it should not be shown unless it is in focus. The new cell_resize code doesn't respect this. To see this:

  1. Load a fresh worksheet with %hide's -- none of them are hidden. Click on input cells then out hide them.
  1. Resize a web browser window with %hides -- suddenly all %hide inputs are shown.

Attachments (1)

sage-3053.patch (2.5 KB) - added by was 6 years ago.

Download all attachments as: .zip

Change History (4)

Changed 6 years ago by was

comment:1 Changed 6 years ago by was

  • Summary changed from notebook -- new cell_resize doesn't respect %hide at the beginning of a cell to [with patch; needs review] notebook -- new cell_resize doesn't respect %hide at the beginning of a cell

Attached patch does this:

trac #3053 -- new cell_resize doesn't respect %hide at the beginning of a cell

  1. Fix the listed problem.
  2. Fix the %hide styling a bit; make %hide be grey
  3. Make %hide work consistently on new page refresh versus in a running worksheet
  4. Make cell be resized when clicking on an input area. This makes editing a %hide much more natural.

comment:2 Changed 6 years ago by boothby

  • Summary changed from [with patch; needs review] notebook -- new cell_resize doesn't respect %hide at the beginning of a cell to [with patch; positive review] notebook -- new cell_resize doesn't respect %hide at the beginning of a cell

nice!

comment:3 Changed 6 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged in Sage 3.0.2.alpha1

Note: See TracTickets for help on using tickets.