Opened 7 years ago

Closed 6 years ago

Last modified 6 years ago

#3044 closed enhancement (fixed)

[with patch, positive review] phcpack improvements: path tracking

Reported by: mhampton Owned by: somebody
Priority: minor Milestone: sage-3.0.4
Component: numerical Keywords: phcpack, interfaces, optional packages, editor_cwitty
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

I (Marshall Hampton) and Alex Jokela have added a number of improvements to the phcpack interface, including solution classification, path-tracking, and some utility functions. This also includes much better doctesting.

Attachments (2)

trac_3044_phcpack.patch (37.7 KB) - added by mhampton 7 years ago.
phcpack-optional.patch (808 bytes) - added by cwitty 7 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 7 years ago by mhampton

  • Keywords phcpack interfaces optional packages added

Changed 7 years ago by mhampton

comment:2 Changed 7 years ago by mabshoff

  • Milestone set to sage-3.0.1
  • Summary changed from phcpack improvements: path tracking to [with patch, needs review] phcpack improvements: path tracking

comment:3 Changed 7 years ago by mhampton

  • Owner changed from jkantor to somebody

comment:4 Changed 7 years ago by craigcitro

  • Keywords editor_cwitty added

Changed 7 years ago by cwitty

comment:5 Changed 7 years ago by cwitty

  • Summary changed from [with patch, needs review] phcpack improvements: path tracking to [with patch, positive review] phcpack improvements: path tracking

Looks good! Doctests pass with phc installed; the plot looks pretty; and after applying my phcpack-optional.patch, doctests pass without phc installed.

comment:6 Changed 6 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged both patches in Sage 3.0.4.alpha0

comment:7 Changed 6 years ago by mabshoff

  • Milestone changed from sage-3.1.1 to sage-3.0.4
Note: See TracTickets for help on using tickets.