Opened 6 years ago

Closed 6 years ago

#2926 closed enhancement (fixed)

[with patch; positive review] notebook -- Minimalistic change password page for notebook user

Reported by: TimothyClemans Owned by: TimothyClemans
Priority: major Milestone: sage-3.0.2
Component: notebook Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

  • Write resource "passwd" with inspiration from RegistrationPage?
  • Add resource "passwd" to UserTopLevel?
  • Add link to "change password" in the list entries in the function _html_body in notebook.py

Attachments (1)

2926.patch (3.7 KB) - added by TimothyClemans 6 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 6 years ago by TimothyClemans

  • Summary changed from Minilistic change password page for notebook user to notebook -- Minilistic change password page for notebook user

comment:2 Changed 6 years ago by TimothyClemans

  • Summary changed from notebook -- Minilistic change password page for notebook user to notebook -- Minimalistic change password page for notebook user

Changed 6 years ago by TimothyClemans

comment:3 Changed 6 years ago by TimothyClemans

  • Summary changed from notebook -- Minimalistic change password page for notebook user to [with patch; needs review] notebook -- Minimalistic change password page for notebook user

comment:4 Changed 6 years ago by mabshoff

This might be superseded by #2936, but if the functionality is not in there it can probably ported to the new codebase.

Cheers,

Michael

comment:5 Changed 6 years ago by was

  • Summary changed from [with patch; needs review] notebook -- Minimalistic change password page for notebook user to [with patch; positive review] notebook -- Minimalistic change password page for notebook user

This just works. There's no way for a user to actually use it short of explicitly typing /passwd in the URL. But it does work correctly and the underlying code looks good.

I wish it were somehow tested, but I don't know how to test it (yet).

So it's a preliminary and solid step to this functionality, so it should go in.

I don't think it overlaps with #2936 which is more backend stuff, whereas this is more UI oriented.

comment:6 Changed 6 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged in Sage 3.0.2.alpha0

Note: See TracTickets for help on using tickets.