Opened 7 years ago

Closed 7 years ago

#2807 closed defect (fixed)

[with patch, positive review] line 26 of c_lib/src/interrupt.c is wrong

Reported by: dmharvey Owned by: cwitty
Priority: major Milestone: sage-3.0
Component: misc Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

Line 26 of c_lib/src/interrupt.c says:

 if ( _signals.mpio && 1 ) {

it should probably be

if ( _signals.mpio & 1 ) {

Attachments (1)

2807.patch (576 bytes) - added by dmharvey 7 years ago.

Download all attachments as: .zip

Change History (4)

Changed 7 years ago by dmharvey

comment:1 Changed 7 years ago by dmharvey

I've made a patch, have no idea if it will work.

[10:45am] dmharvey: that's #2807
[10:46am] mabshoff: Well, let's hope we close more tickets today than we open.
[10:46am] dmharvey: I can easily close that one, but I wonder if it will introduce strange bugs....
[10:46am] malb: this line means: we always use Sage's signal handler
[10:47am] malb: which isn't too bad apparently if it handles all the signals we come across ;-)
[10:47am] malb: it probably won't change much
[10:47am] dmharvey: i will make a patch

comment:2 Changed 7 years ago by mabshoff

  • Summary changed from line 26 of c_lib/src/interrupt.c is probably wrong to [with patch, positive review] line 26 of c_lib/src/interrupt.c is probably wrong

Patch is correct and passes doctests. Positive review.

Cheers,

Michael

comment:3 Changed 7 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed
  • Summary changed from [with patch, positive review] line 26 of c_lib/src/interrupt.c is probably wrong to [with patch, positive review] line 26 of c_lib/src/interrupt.c is wrong

Merged in Sage 3.0.alpha2

Note: See TracTickets for help on using tickets.