Opened 7 years ago

Closed 6 years ago

#1733 closed defect (fixed)

[with patch; positive review] notebook bug -- %foo (or anything else) in a cell by itself (with nothing else in the cell) does not give an error but it *should*

Reported by: was Owned by: boothby
Priority: major Milestone: sage-3.0.2
Component: notebook Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

This is probably easy to fix in server/notebook/worksheet.py

Attachments (1)

sage-1733.patch (2.0 KB) - added by was 6 years ago.

Download all attachments as: .zip

Change History (4)

Changed 6 years ago by was

comment:1 Changed 6 years ago by was

  • Summary changed from notebook bug -- %foo (or anything else) in a cell by itself (with nothing else in the cell) does not give an error but it *should* to [with patch; needs review] notebook bug -- %foo (or anything else) in a cell by itself (with nothing else in the cell) does not give an error but it *should*

The attached patch:

  1. Fixed the problem where %foobar with no input in the cell didn't give an error -- now it does, about

foobar not being defined.

  1. While I was at it I improved how %foo modes in the notebook work, so that they can have everything on one line, e.g.,
       %magma Factorization(9038049823)
    

on a single line works in the notebook.

  1. NOTE that the actual patch replaces a bunch of crappy hard to understand code with like 3 simple

lines that fix all of the above.

comment:2 Changed 6 years ago by boothby

  • Summary changed from [with patch; needs review] notebook bug -- %foo (or anything else) in a cell by itself (with nothing else in the cell) does not give an error but it *should* to [with patch; positive review] notebook bug -- %foo (or anything else) in a cell by itself (with nothing else in the cell) does not give an error but it *should*

Great stuff! Works well, and makes the code cleaner!

comment:3 Changed 6 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged in Sage 3.0.2.alpha1

Note: See TracTickets for help on using tickets.