Opened 9 months ago

Closed 8 months ago

Last modified 8 months ago

#16090 closed defect (fixed)

Set() should return an empty Set

Reported by: mathzeta2 Owned by:
Priority: minor Milestone: sage-6.2
Component: misc Keywords: set, days57
Cc: Merged in:
Authors: Tomer Bauer Reviewers: Nathann Cohen
Report Upstream: N/A Work issues:
Branch: 66c6970 (Commits) Commit:
Dependencies: Stopgaps:

Description

Set with no argument is currently an error. It should be changed to follow what Python's built-in container constructors do: return an empty container.

Change History (9)

comment:1 Changed 9 months ago by mathzeta2

  • Branch set to u/mathzeta2/ticket/16090
  • Created changed from 04/07/14 14:35:27 to 04/07/14 14:35:27
  • Modified changed from 04/07/14 14:35:27 to 04/07/14 14:35:27

comment:2 follow-up: Changed 8 months ago by tscrim

  • Commit set to 66c697044750056f84e424c051eb742353b04cd3

Is this ready for review?


New commits:

66c6970Set() with no argument returns an empty Set.

comment:3 Changed 8 months ago by ncohen

  • Status changed from new to needs_review

comment:4 Changed 8 months ago by ncohen

  • Status changed from needs_review to positive_review

comment:5 Changed 8 months ago by vbraun

  • Reviewers set to Nathann Cohen

reviewer name...

comment:6 in reply to: ↑ 2 Changed 8 months ago by mathzeta2

Replying to tscrim:

Is this ready for review?

(After a fix to the time machine:) I think it is.

You might argue what the default value should be. It probably should not be None because of #16092.

comment:7 Changed 8 months ago by ncohen

I would have taken an empty tuple, but it does not matter much I guess..

Nathann

comment:8 Changed 8 months ago by vbraun

  • Branch changed from u/mathzeta2/ticket/16090 to 66c697044750056f84e424c051eb742353b04cd3
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:9 Changed 8 months ago by ncohen

  • Commit 66c697044750056f84e424c051eb742353b04cd3 deleted

Hey Volker, share your releases ! It is not fair that you are the only one to enjoy all the nice new features :-P

Nathann

Note: See TracTickets for help on using tickets.