Opened 8 months ago

Closed 8 months ago

#16057 closed defect (fixed)

Fix multiplicity of nodes in Kleber tree

Reported by: tscrim Owned by: sage-combinat
Priority: major Milestone: sage-6.2
Component: combinatorics Keywords: rigged configurations
Cc: sage-combinat, aschilling Merged in:
Authors: Travis Scrimshaw Reviewers: Anne Schilling
Report Upstream: N/A Work issues:
Branch: f86beb5 (Commits) Commit: f86beb59566af98e13af4ee6ae032eaa68a82bc7
Dependencies: Stopgaps:

Description (last modified by tscrim)

The formula should read:

p_i^{(a)} = ( \alpha_a | \lambda^{(i)} ) - \sum_{j > i} (j - i) L_j^{(a)}.

The old formula caused the multiplicities to become too large.

Change History (12)

comment:1 Changed 8 months ago by tscrim

  • Branch set to public/combinat/fix_kleber_tree_multiplicities-16057
  • Status changed from new to needs_review

comment:2 Changed 8 months ago by tscrim

  • Branch changed from public/combinat/fix_kleber_tree_multiplicities-16057 to public/combinat/fix_kleber_tree_multiplicity-16057
  • Commit set to 395a6493d10e9534f3908ef478de42a4c8260144

New commits:

395a649Fix for the multiplicitys of the Kleber tree nodes.

comment:3 Changed 8 months ago by git

  • Commit changed from 395a6493d10e9534f3908ef478de42a4c8260144 to d17f2cd2a36db59af1a85f118c837dc90944d4e1

Branch pushed to git repo; I updated commit sha1. New commits:

d17f2cdThe max is unnecessary.

comment:4 Changed 8 months ago by tscrim

  • Description modified (diff)

comment:5 Changed 8 months ago by aschilling

  • Keywords rigged configurations added
  • Reviewers set to Anne Schilling
  • Status changed from needs_review to positive_review

comment:6 Changed 8 months ago by git

  • Commit changed from d17f2cd2a36db59af1a85f118c837dc90944d4e1 to 46ea05bf9b70f66becb1f8e8b9660b9bcfeee261
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

46ea05bMinor speedup to Kleber tree.

comment:7 Changed 8 months ago by tscrim

It's faster to do it this way:

sage: B = [[1,2]]*50
sage: %timeit for (r,s) in B: r,s
100000 loops, best of 3: 6.61 µs per loop
sage: %timeit for b in B: b[0], b[1]
10000 loops, best of 3: 22.4 µs per loop

comment:8 Changed 8 months ago by tscrim

  • Status changed from needs_review to positive_review

comment:9 Changed 8 months ago by tscrim

Thanks for doing the review.

comment:10 Changed 8 months ago by git

  • Commit changed from 46ea05bf9b70f66becb1f8e8b9660b9bcfeee261 to f86beb59566af98e13af4ee6ae032eaa68a82bc7
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

f86beb5Removed extraneous comment.

comment:11 Changed 8 months ago by tscrim

  • Status changed from needs_review to positive_review

Sorry, one other micro change.

comment:12 Changed 8 months ago by vbraun

  • Branch changed from public/combinat/fix_kleber_tree_multiplicity-16057 to f86beb59566af98e13af4ee6ae032eaa68a82bc7
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.