Opened 6 years ago

Closed 6 years ago

#1542 closed defect (fixed)

[with patch] R package doesn't notice if rpy fails to build

Reported by: craigcitro Owned by: craigcitro
Priority: minor Milestone: sage-2.9.1
Component: packages: standard Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

I think the title says it all; the issue is that no return value is checked, so R doesn't know that anything is wrong. The attached patch just adds a check in spkg-install to make sure everything went okay with the rpy install.

Attachments (1)

1542.patch (600 bytes) - added by craigcitro 6 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 6 years ago by craigcitro

  • Summary changed from R package doesn't notice if rpy fails to build to [with patch] R package doesn't notice if rpy fails to build

The patch is against r-2.6.1.p6.spkg (I forgot to mention that above, though it probably goes without saying).

comment:2 Changed 6 years ago by craigcitro

  • Status changed from new to assigned

Changed 6 years ago by craigcitro

comment:3 Changed 6 years ago by craigcitro

Posted new version of the patch, which reflects the updated name for the rpy-1.0.1.p0.spkg. (I also added a variable so that the rpy spkg name only appears once, instead of twice, making it less likely that someone would accidentally change one and not the other.)

comment:4 Changed 6 years ago by rlm

  • Resolution set to fixed
  • Status changed from assigned to closed

Merged in 2.9.1.alpha1

Note: See TracTickets for help on using tickets.