Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#1524 closed defect (duplicate)

fix various issues with #1239

Reported by: was Owned by: was
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: number theory Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

[12:01am] cwitty-rvw-1473: and you're confident that incidentally merging the extcode patches from 1239 doesn't hurt anything?
[12:01am] wstein-1183: yes.
[12:01am] wstein-1183: wait!
[12:02am] wstein-1183: It will completely break things
[12:02am] wstein-1183: I.e., it will break simon 2 descent
[12:02am] wstein-1183: however, I think robert is fixing the updated simon 2 descent now.
[12:02am] wstein-1183: There is nothing truly broken about that -- it just needs some polish.
[12:02am] wstein-1183: So I would recommend merging 1472 and 1239, but opening a ticket to polish 1239.
[12:03am] wstein-1183: Since 1239 works.
[12:03am] wstein-1183: it's just easy to get lies from some of the new functions 
[12:03am] jkantor: linking may be fine, but that would be about all . . .
[12:04am] cwitty-rvw-1473: Sounds good to me.  Do you want to change your review of 1239, and open the new ticket?
[12:04am] wstein-1183: yes

Change History (2)

comment:1 Changed 6 years ago by robertwb

  • Priority changed from blocker to major
  • Resolution set to duplicate
  • Status changed from new to closed

This was resolved in #1239 after all...

comment:2 Changed 6 years ago by mabshoff

  • Milestone changed from sage-2.9 to sage-duplicate/invalid
Note: See TracTickets for help on using tickets.