Opened 7 months ago

Closed 7 months ago

#15204 closed defect (fixed)

Fix gap cyclotomics to sage

Reported by: tscrim Owned by: tscrim
Priority: major Milestone: sage-5.12
Component: interfaces Keywords:
Cc: Merged in: sage-5.12.rc0
Authors: Travis Scrimshaw Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by tscrim)

Current gap expects a particular method of _n() which is provided by CyclotomicField but not by others, in particular UniversalCyclotomicField.

sage: libgap.E(3).sage(ring=UniversalCyclotomicField())
AttributeError: 'UniversalCyclotomicField_with_category' object has no attribute '_n'

This ticket fixes this by catching this exception and converting through the CyclotomicField.

Attachments (1)

trac_15204-fix_gap_cyclotomics-ts.patch (1.4 KB) - added by tscrim 7 months ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 7 months ago by tscrim

  • Description modified (diff)
  • Status changed from new to needs_review

comment:2 Changed 7 months ago by chapoton

that :trac:`12345` is fixed

really ?

Changed 7 months ago by tscrim

comment:3 Changed 7 months ago by tscrim

*waves hand* That's not the placeholder you're looking for.

comment:4 Changed 7 months ago by chapoton

Hello Travis :)

Now that we are trusted again, I am afraid there is no longer any patchbot around for the mercurial tickets. At least the only active one (except my own one) seems to work only on git tickets.

I will try to find time to run my patchbot on this ticket. It takes me around 90m per ticket... Maybe you could run a patchbot too ?

Frederic

comment:5 Changed 7 months ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, looks good to me.

comment:6 Changed 7 months ago by tscrim

Thanks Frederic.

comment:7 Changed 7 months ago by jdemeyer

  • Merged in set to sage-5.12.rc0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.