Opened 7 years ago

Closed 7 years ago

#1519 closed defect (fixed)

[with patch, with positive review] hg problem -- This should work but doesn't: sage: hg_sage.apply('http://trac.sagemath.org/sage_trac/attachment/ticket/1514/trac-1514.patch?format=raw')

Reported by: was Owned by: was
Priority: major Milestone: sage-2.9
Component: user interface Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

Doing

sage: hg_sage.apply('http://trac.sagemath.org/sage_trac/attachment/ticket/1514/trac-1514.patch?format=raw')

should work, but doesn't, because of the ?stuff at the end. Fix this.

How to test the patch: Try applying a patch or bundle by pasting in the URL to the raw format as in the example above.

Attachments (1)

trac-1519.patch (1.4 KB) - added by was 7 years ago.

Download all attachments as: .zip

Change History (4)

Changed 7 years ago by was

comment:1 Changed 7 years ago by was

  • Summary changed from hg problem -- This should work but doesn't: sage: hg_sage.apply('http://trac.sagemath.org/sage_trac/attachment/ticket/1514/trac-1514.patch?format=raw') to [with patch] hg problem -- This should work but doesn't: sage: hg_sage.apply('http://trac.sagemath.org/sage_trac/attachment/ticket/1514/trac-1514.patch?format=raw')

Note -- there is no easy way to doctest this, since it requires existence of a specific file on the internet with a funny ? in its filename..., and to apply that patch to a repository...

comment:2 Changed 7 years ago by mabshoff

  • Summary changed from [with patch] hg problem -- This should work but doesn't: sage: hg_sage.apply('http://trac.sagemath.org/sage_trac/attachment/ticket/1514/trac-1514.patch?format=raw') to [with patch, with positive review] hg problem -- This should work but doesn't: sage: hg_sage.apply('http://trac.sagemath.org/sage_trac/attachment/ticket/1514/trac-1514.patch?format=raw')

looks good to me and is quite useful.

Cheers,

Michael

comment:3 Changed 7 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged in 2.9.rc0.

Note: See TracTickets for help on using tickets.