Opened 9 months ago

Closed 8 months ago

#14987 closed defect (fixed)

Dilation of empty polyhedra

Reported by: caruso Owned by:
Priority: major Milestone: sage-5.12
Component: geometry Keywords: polyhedra
Cc: Merged in: sage-5.12.beta2
Authors: Xavier Caruso Reviewers: Nathann Cohen
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

There is a bug in the dilation of polyhedra (compare the ambient dimensions):

sage: p = Polyhedron(ambient_dim=2); p
The empty polyhedron in ZZ^2
sage: p.dilation(3)
The empty polyhedron in ZZ^0

The attached patch fixes this.

Attachments (1)

trac_14987_dilation_polyhedrons.patch (1.3 KB) - added by caruso 9 months ago.

Download all attachments as: .zip

Change History (4)

comment:1 Changed 9 months ago by ncohen

  • Reviewers set to Nathann Cohen
  • Status changed from new to needs_review

Could you replace the reference to the trac ticket by :trac:`14987` ? That's how we should write it now :-)

Once this is done, you can set this ticket to positive_review on my behalf.

Thaaaaaaaaaaaanks !

Nathann

P.S. : Oh, and there is also a :: immediately after TESTS which should be a single :.

Changed 9 months ago by caruso

comment:2 Changed 9 months ago by caruso

  • Status changed from needs_review to positive_review

Done. Thanks for your review.

comment:3 Changed 8 months ago by jdemeyer

  • Merged in set to sage-5.12.beta2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.