Opened 7 years ago

Closed 7 years ago

#1464 closed enhancement (fixed)

[with patch, positive review] binary code canonical labels & automorphism group generators

Reported by: rlm Owned by: rlm
Priority: major Milestone: sage-2.9
Component: coding theory Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

The following bundle is based on 2.9 alpha5, so should merge easily

http://sage.math.washington.edu/home/rlmill/sage-2.9.alpha5/binary_codes.hg

Note that the coverage in the new file, binary_codes.pyx, is 100%.

Change History (6)

comment:1 Changed 7 years ago by rlm

  • Status changed from new to assigned

comment:2 Changed 7 years ago by jsp

The bundle worked for me on Fedora 7.

sage -t  devel/sage-main/sage/coding/binary_code.pyx        
         [2.8 s]
 
----------------------------------------------------------------------
All tests passed!

[jaap@paix sage-2.9.alpha5]$ ./sage -t devel/sage/sage/graphs*
sage -t  devel/sage-main/sage/graphs/print_graphs.py        
         [1.5 s]
sage -t  devel/sage-main/sage/graphs/graph_database.py      
         [12.9 s]
sage -t  devel/sage-main/sage/graphs/graph_fast.pyx         
         [1.8 s]
sage -t  devel/sage-main/sage/graphs/graph_list.py          
         [8.9 s]
sage -t  devel/sage-main/sage/graphs/graph_genus1.py        
         [12.8 s]
sage -t  devel/sage-main/sage/graphs/graph.py               
         [36.8 s]
sage -t  devel/sage-main/sage/graphs/linearextensions.py    
         [1.5 s]
sage -t  devel/sage-main/sage/graphs/graph_isom.pyx         
         [28.6 s]
sage -t  devel/sage-main/sage/graphs/all.py                 
         [1.5 s]
sage -t  devel/sage-main/sage/graphs/graph_generators.py    
         [61.9 s]
sage -t  devel/sage-main/sage/graphs/bruhat_sn.pyx          
         [1.6 s]
 
----------------------------------------------------------------------
All tests passed!
Total time for all tests: 169.8 seconds

comment:3 Changed 7 years ago by rlm

  • Milestone changed from sage-2.9 to sage-2.9.1

There are still some bugs...

comment:4 Changed 7 years ago by rlm

  • Milestone changed from sage-2.9.1 to sage-2.9

comment:5 Changed 7 years ago by was

  • Summary changed from [with patch] binary code canonical labels & automorphism group generators to [with patch, positive review] binary code canonical labels & automorphism group generators

Do this after applying the bundle:

was@sage:~/build/sage-2.9.rc0/devel/sage/sage/coding$ hg rm binary_code_backup.pyx 
was@sage:~/build/sage-2.9.rc0/devel/sage/sage/coding$ hg ci

comment:6 Changed 7 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from assigned to closed

Merged in 2.9.rc2.

Note: See TracTickets for help on using tickets.