Opened 7 years ago

Closed 7 years ago

#1361 closed defect (fixed)

[with patch, with positive review] reimplement graph generation

Reported by: rlm Owned by: rlm
Priority: major Milestone: sage-2.8.15
Component: combinatorics Keywords: graphs
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

Changes:

  1. Redefine order to be number of edges.
  2. Start with empty graph.
  3. Augment by adding 1 edge.
  4. Cython-ize.

Attachments (1)

graph_gen.hg (5.3 KB) - added by rlm 7 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 7 years ago by rlm

  • Owner changed from mhansen to rlm
  • Status changed from new to assigned

comment:2 Changed 7 years ago by rlm

  • Milestone changed from sage-2.10 to sage-2.8.15

Changed 7 years ago by rlm

comment:3 Changed 7 years ago by rlm

Implementing in Cython should have little effect, since what is in Python is certainly not the bottleneck.

comment:4 Changed 7 years ago by rlm

  • Summary changed from reimplement graph generation to [with patch] reimplement graph generation

comment:5 Changed 7 years ago by cwitty

  • Summary changed from [with patch] reimplement graph generation to [with patch, with positive review] reimplement graph generation

Looks good to me. (Code looks reasonable, doctests pass in sage/graphs/.)

comment:6 Changed 7 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from assigned to closed

Merged in 2.8.15.alpha2.

Note: See TracTickets for help on using tickets.