Opened 6 years ago

Closed 6 years ago

#1333 closed enhancement (fixed)

[with trivial patch, with positive review] fix a major inefficiency in floating point square root computation in Sage

Reported by: was Owned by: somebody
Priority: major Milestone: sage-2.8.15
Component: basic arithmetic Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

Paul Zimmerman's benchmarks unveiled a serious slowdown in x.sqrt() for x mpfr.

This patch fixes the problem.

Attachments (1)

trac1333.patch (1.2 KB) - added by was 6 years ago.

Download all attachments as: .zip

Change History (3)

Changed 6 years ago by was

comment:1 Changed 6 years ago by cwitty

  • Summary changed from [with trivial patch] fix a major inefficiency in floating point square root computation in Sage to [with trivial patch, with positive review] fix a major inefficiency in floating point square root computation in Sage

(I didn't actually test it, but...) looks good to me.

comment:2 Changed 6 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged in 2.8.15.alpha1.

Note: See TracTickets for help on using tickets.