Opened 6 years ago

Closed 6 years ago

#1331 closed defect (fixed)

[with patch, with positive review] 2.8.14/Solaris: fix complex_double doctest - numerical noise

Reported by: mabshoff Owned by: mabshoff
Priority: major Milestone: sage-2.8.15
Component: doctest coverage Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by mabshoff)

On Solaris I get the following doctest failures due to numerical noise:

sage -t  devel/sage-main/sage/rings/complex_double.pyx      
**********************************************************************
File "complex_double.pyx", line 1496:
    sage: z^2 - z + 1
Expected:
    2.22044604925e-16 + 1.11022302463e-16*I
Got:
    2.22044604925e-16 + 2.22044604925e-16*I

The attached patch fixes that.

Cheers,

Michael

Attachments (1)

Sage-2.8.14-fix-complex_double-doctest-failure-on-Sparc.patch (795 bytes) - added by mabshoff 6 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 6 years ago by mabshoff

  • Status changed from new to assigned

comment:2 Changed 6 years ago by mabshoff

  • Description modified (diff)

comment:3 Changed 6 years ago by cwitty

  • Summary changed from [with patch] 2.8.14/Solaris: fix complex_double doctest - numerical noise to [with patch, with positive review] 2.8.14/Solaris: fix complex_double doctest - numerical noise

We need another approach for this... what if on another machine, the imaginary component is exactly zero?

But let's cross that bridge when we come to it.

Looks good to me.

comment:4 Changed 6 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from assigned to closed

Merged in 2.8.15.alpha0.

Note: See TracTickets for help on using tickets.