Opened 6 years ago

Closed 6 years ago

#1256 closed task (fixed)

mwrank*.spkg now redundant, included in cremona*.spkg

Reported by: cremona Owned by: mabshoff
Priority: minor Milestone: sage-2.9
Component: algebraic geometry Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

The code in the new cremona* package contains all of what was in the mwrank* package. So the latter can be abandoned as soon as the wrappings for mwrank functions have been migrated. This will only be really serious when I next fix a bug in mwrank -- since from now on I'll only be editing the version which is part of cremona*.

I'm sure this is an easy job for someone who is familiar with the mwrank wrappings (not me, alas, though I suppose I should be).

Attachments (3)

Sage-2.9.alpha0-mwrank-cremona-transition.patch (2.1 KB) - added by mabshoff 6 years ago.
deps (9.4 KB) - added by mabshoff 6 years ago.
install (4.6 KB) - added by mabshoff 6 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 6 years ago by mabshoff

I am taking care of this. The following things need to be done:

[18:17] <was_> Definitely the solution is to (1) remove the mwrank*spkg.
[18:17] <was_> (2) copy over the mwrank executable which gets build as part of cremona*.spkg
[18:17] <was_> (3) Change things in setup.py so that all the prober mwrank-related libraries are linked in (it's maybe 4 libraries now instead of 1)

Cheers,

Michael

comment:2 Changed 6 years ago by mabshoff

  • Owner changed from was to mabshoff
  • Status changed from new to assigned

comment:3 Changed 6 years ago by mabshoff

Ok, the following binaries are installed my mwrank:

  • mwrank
  • tmrank
  • ratpoint
  • findinf
  • tate
  • conductor
  • torsion
  • twist
  • allisog
  • indep
  • tconic

Changed 6 years ago by mabshoff

Changed 6 years ago by mabshoff

comment:4 Changed 6 years ago by mabshoff

Ok, I updated cremona.spkg to also install all mwrank binaries. It is at

http://sage.math.washington.edu/home/mabshoff/cremona-20071124.p3.spkg

Cheers,

Michael

comment:5 Changed 6 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from assigned to closed

Merged in 2.9.alpha0.

Note: See TracTickets for help on using tickets.