Opened 7 years ago

Closed 7 years ago

#1106 closed enhancement (fixed)

[with patch, positive review] speed up dense matrix comparison

Reported by: malb Owned by: mhansen
Priority: major Milestone: sage-2.9.1
Component: linear algebra Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

The general implementation right now is:

cdef int _cmp_c_impl(self, Element right) except -2:
    return cmp(self._list(), right._list())

which has a huge memory overhead. This should be optimised. Also, Matrix_modn_dense should have a faster special cmp method.

Attachments (1)

1106.patch (1.3 KB) - added by mhansen 7 years ago.

Download all attachments as: .zip

Change History (4)

comment:1 Changed 7 years ago by mabshoff

  • Milestone changed from sage-2.10 to sage-2.9.1

Changed 7 years ago by mhansen

comment:2 Changed 7 years ago by mhansen

  • Owner changed from was to mhansen
  • Status changed from new to assigned
  • Summary changed from speed up dense matrix comparison to [with patch] speed up dense matrix comparison

comment:3 Changed 7 years ago by rlm

  • Resolution set to fixed
  • Status changed from assigned to closed
  • Summary changed from [with patch] speed up dense matrix comparison to [with patch, positive review] speed up dense matrix comparison

merged in 2.9.1 rc0

Note: See TracTickets for help on using tickets.