Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#10559 closed defect (duplicate)

path to perl hardcoded in gphelp (GP/PARI)

Reported by: mariah Owned by: tdb
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: relocation Keywords: pari gphelp
Cc: Merged in:
Authors: Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

The first line of /usr/bin/gphelp has the path to perl hardcoded rather than using

/usr/bin/env perl.

This can be a problem at sites where perl is kept in a non-standard location.

Change History (9)

comment:1 Changed 3 years ago by jdemeyer

  • Keywords pari gphelp added
  • Status changed from new to needs_info

Actually, the path to perl is not hardcoded, the first line of gphelp is written when PARI is installed. So is there still a problem then?

comment:2 follow-up: Changed 3 years ago by wjp

That sounds like it could be a problem with binary releases of sage.

comment:3 in reply to: ↑ 2 Changed 3 years ago by jdemeyer

  • Status changed from needs_info to needs_work

Replying to wjp:

That sounds like it could be a problem with binary releases of sage.

I guess you're right. Anyway, it's a trivial fix to replace the first line of doc/gphelp.in by #!/usr/bin/env perl, but this should be included in #10430.

comment:4 Changed 3 years ago by was

Jeroen points out that we should fix this exact issue in a whole bunch (=6) of files (and of course get this upstreamed eventually). All probably related to the documentation.

comment:5 Changed 3 years ago by jdemeyer

Unfortunately some of the other files use

#!/usr/bin/perl -w

and there is no easy env replacement for that. Since -w only enables warnings, we could just remove that switch, but I don't think that's such a good idea. Suggestions?

comment:6 Changed 3 years ago by jdemeyer

doc/gphelp.in:#!@perl@
misc/tex2mail.in:#!@perl@
src/desc/PARI/822.pm:#!/usr/bin/perl -w
src/desc/merge_822:#!/usr/bin/perl -w
src/desc/whatnow:#!/usr/bin/perl -w
src/desc/gen_proto:#!/usr/bin/perl -w
src/desc/doc_make:#!/usr/bin/perl
src/graph/plotport.c:#!/usr/bin/perl

comment:7 Changed 3 years ago by jdemeyer

Just for the record: perl is not required to build PARI/GP (you get lots of warnings/errors during the build because the documentation can't be built but gp works fine).

comment:8 Changed 3 years ago by jdemeyer

  • Resolution set to duplicate
  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_work to closed

There is a patch in the updated PARI spkg at #10430, so I'm closing this as duplicate.

comment:9 Changed 3 years ago by mvngu

  • Milestone set to sage-duplicate/invalid/wontfix
Note: See TracTickets for help on using tickets.