Opened 4 years ago

Closed 3 years ago

#10292 closed defect (fixed)

padics, precision, list() and printing

Reported by: roed Owned by: roed
Priority: minor Milestone: sage-4.8
Component: padics Keywords:
Cc: Merged in: sage-4.8.alpha4
Authors: David Roe Reviewers: Johan Bosman
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by johanbosman)

sage: E = EllipticCurve('37a')
sage: R = E.padic_regulator(7)
sage: len(R.list())
37
sage: s = str(R)
sage: len(R.list())
19

Similarly:

sage: E = EllipticCurve('37a')
sage: R = E.padic_regulator(7)
sage: len(R.list())
37
sage: R.precision_absolute()
20
sage: len(R.list())
37
sage: R.precision_relative()
19
sage: len(R.list())
19

This is likely due to _normalize not getting called when necessary at object creation.

Apply:

  1. 10292.patch
  2. 10292_review.patch

to the sage repository.

Attachments (2)

10292.patch (3.3 KB) - added by roed 3 years ago.
10292_review.patch (1.0 KB) - added by johanbosman 3 years ago.

Download all attachments as: .zip

Change History (6)

Changed 3 years ago by roed

comment:1 Changed 3 years ago by roed

  • Status changed from new to needs_review

Changed 3 years ago by johanbosman

comment:2 Changed 3 years ago by johanbosman

  • Authors set to David Roe
  • Description modified (diff)
  • Reviewers set to Johan Bosman

I've uploaded a patch that fixes the docstring formatting. If you agree with this, this can be given a positive_review.

comment:3 Changed 3 years ago by roed

  • Status changed from needs_review to positive_review

Looks good to me. I should look over the Sphinx documentation to see when .. is advisable. The lack of :: was just an oversight.

comment:4 Changed 3 years ago by jdemeyer

  • Merged in set to sage-4.8.alpha4
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.