Ticket #9968 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

Stop Dancing Links polluting the global namespace

Reported by: davidloeffler Owned by: sage-combinat
Priority: trivial Milestone: sage-4.6
Component: combinatorics Keywords: dancing links
Cc: Work issues:
Report Upstream: N/A Reviewers: Nathann Cohen
Authors: David Loeffler Merged in: sage-4.6.alpha2
Dependencies: Stopgaps:

Description

The Dancing Links class defines a bunch of random integer variables (LEFT, RIGHT, UP, DOWN, ROOTNODE) and exports these to the global namespace. This is kind of sloppy and unprofessional: 

----------------------------------------------------------------------
| Sage Version 4.6.alpha1, Release Date: 2010-09-18                  |
| Type notebook() for the GUI, and license() for information.        |
----------------------------------------------------------------------
**********************************************************************
*                                                                    *
* Warning: this is a prerelease version, and it may be unstable.     *
*                                                                    *
**********************************************************************
Loading Sage library. Current Mercurial branch is: hacking
sage: UP
2

Attachments

trac_9968.patch Download (694 bytes) - added by davidloeffler 3 years ago.
patch against 4.6.alpha1

Change History

Changed 3 years ago by davidloeffler

patch against 4.6.alpha1

comment:1 Changed 3 years ago by davidloeffler

  • Status changed from new to needs_review

comment:2 Changed 3 years ago by ncohen

  • Status changed from needs_review to positive_review
  • Reviewers set to Nathann Cohen

I was a bit worried about the edge_coloring method for graphs which uses this algorithm, but it is still working after this patch is applied : no (related) failure in sage -testall !

Thankssssssssss ! :-)

Nathann

comment:3 Changed 3 years ago by davidloeffler

  • Milestone changed from sage-4.6.1 to sage-4.6

Perhaps we can get this into 4.6? It's hardly a massive change :-)

comment:4 Changed 3 years ago by mpatel

  • Status changed from positive_review to closed
  • Resolution set to fixed
  • Merged in set to sage-4.6.alpha2
Note: See TracTickets for help on using tickets.