Ticket #9796 (closed enhancement: fixed)

Opened 21 months ago

Last modified 15 months ago

Add a "diagonal" method for matrices

Reported by: jason Owned by: jason, was
Priority: major Milestone: sage-4.6.2
Component: linear algebra Keywords: beginner
Cc: kcrisman Work issues:
Report Upstream: N/A Reviewers: Tom Coates
Authors: Rob Beezer Merged in: sage-4.6.2.rc0
Dependencies: Stopgaps:

Description

See  http://ask.sagemath.org/question/54/how-to-get-the-diagonal-of-a-matrix

Attachments

trac_9796-matrix-diagonal-elements.patch Download (1.7 KB) - added by rbeezer 16 months ago.

Change History

comment:1 Changed 21 months ago by kcrisman

  • Cc kcrisman added

Changed 16 months ago by rbeezer

comment:2 Changed 16 months ago by rbeezer

  • Keywords beginner added
  • Status changed from new to needs_review

comment:3 follow-up: ↓ 4 Changed 16 months ago by tomc

  • Status changed from needs_review to positive_review
  • Reviewers set to tomc

This looks good. Running: 

sage -testall -long

gives that all doctests pass except five unrelated tests (in sage/plot/plot3d/tachyon.py and sage/plot/plot3d/base.pyx) that also fail in an unpatched copy of Sage (version 4.6.1, built from source on 64-bit Linux).

comment:4 in reply to: ↑ 3 Changed 16 months ago by rbeezer

Replying to tomc:

Thanks for the review, Tom - the help is appreciated.

Rob

comment:5 follow-up: ↓ 6 Changed 16 months ago by kcrisman

  • Reviewers changed from tomc to Tom Coates
  • Authors set to Rob Beezer

I hope it's okay that I 'guessed' the reviewer's name from the trac main page!

comment:6 in reply to: ↑ 5 Changed 15 months ago by jdemeyer

Replying to kcrisman:

I hope it's okay that I 'guessed' the reviewer's name from the trac main page!

I suppose so, I do that all the time.

comment:7 Changed 15 months ago by jdemeyer

  • Status changed from positive_review to closed
  • Resolution set to fixed
  • Merged in set to sage-4.6.2.rc0
Note: See TracTickets for help on using tickets.