Ticket #9783 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

Add additive groups to the documentation

Reported by: rbeezer Owned by: joyner
Priority: major Milestone: sage-4.5.3
Component: group theory Keywords:
Cc: cremona Work issues:
Report Upstream: N/A Reviewers: John Cremona
Authors: Rob Beezer Merged in: sage-4.5.3.rc0
Dependencies: Stopgaps:

Description

Add the relatively new additive group documentation from #6449 into the reference manual and verify that it builds properly.

Attachments

trac_9783_abelian_groups_docs.patch Download (5.3 KB) - added by rbeezer 3 years ago.

Change History

Changed 3 years ago by rbeezer

comment:1 Changed 3 years ago by rbeezer

  • Status changed from new to needs_review

Patch:

1) Adds the modules for additive abelian groups to the documentation, which builds just fine.

2) Some minor touchups and additions to the documentation.

3) I removed the note about the output format, as this seems to have been fixed.

4) I added some doctests about creating elements, since this had me very confused when I created #9695.

comment:2 Changed 3 years ago by cremona

  • Status changed from needs_review to positive_review
  • Reviewers set to John Cremona
  • Authors set to Rob Beezer

Good job (especially the extra notes). Applies fine to 4.5.3.alpha1, builds with no problems, and the output looks good.

comment:3 Changed 3 years ago by mpatel

  • Status changed from positive_review to closed
  • Resolution set to fixed
  • Merged in set to sage-4.5.3.rc0
Note: See TracTickets for help on using tickets.